605342 - [RTL] after typing in arabic characters, the arabic characters are not right justified on the awesome page

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect, P4)

Description

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: Android Droid 2 Screenshot

1. install arabic plugin : (ie http://people.mozilla.com/~nhirata/html_tp/installplugin.html - first link), restart
2. set browser language to arabic, restart
3. install Arabic Soft Keyboard
4. set IME on Android to use Arabic Soft Keyboard
5. close the hardware keyboard
6. click in the awesome bar
7. type in arabic
8. dismiss the keyboard

Expected: the text is right justified
Actual: the text is left justified

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Duping with bug 605303, which is the opposite of this bug

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Attachment: Droid 2 Screenshot

RTL languages should have the text to the right not left.  Reopened

Comment 3

[Anas Husseini [:linostar]]

Attachment: patch

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 537335 [details] [diff] [review]
patch

># HG changeset patch
># Parent c39f81636f5b0f8e443134573dad1b9450d3dcc2
>
>diff -r c39f81636f5b mobile/themes/core/browser.css
>--- a/mobile/themes/core/browser.css	Wed Jun 01 13:29:19 2011 +0300
>+++ b/mobile/themes/core/browser.css	Sat Jun 04 11:57:35 2011 +0300
>@@ -212,6 +212,11 @@
>   padding: @padding_xxxnormal@ @padding_normal@;
> }
> 
>+/* making the url-title right-aligned for rtl locales */
>+#urlbar-title:-moz-locale-dir(rtl) {
>+  text-align: right;
>+}
>+

Any reason for not using {
 text-align: start;
}; ?

> #urlbar-title.placeholder {
>   color: gray;
> }
>@@ -245,6 +250,7 @@
> #urlbar-edit:-moz-locale-dir(rtl) {
>   -moz-border-radius-topright: @border_radius_normal@;
>   -moz-border-radius-bottomright: @border_radius_normal@;
>+  text-align: right; /* making the url editbox right-aligned for rtl locales */
> }

Same as above.

Comment 5

[Anas Husseini [:linostar]]

Attachment: patch v1.1

Adjusted the patch.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 538203 [details] [diff] [review]
patch v1.1

Sorry for the delay to r? this patch :/

Comment 7

[Anas Husseini [:linostar]]

No worries.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Could you provide a checkin message? Preferably in the patch as described at <https://developer.mozilla.org/en/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3f>.

Comment 9

[Andreea Pod]

Attachment: RTL punctuation

I noticed that the punctuation for "Your tabs from last time" on home page is not right as you can see in the screenshot. Is this related to this bug?

Build: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a2) Gecko/20110705 Firefox/6.0a2 Fennec/6.0a2

Comment 10

[Boris Zbarsky [:bzbarsky]]

Removing checkin-needed pending a response to comment 8.  I can't check this in with no checkin message...

Comment 11

[Cristian Nicolae (:xti)]

Attachment: Screenshot

I've browsed to www.yahoo.com and I've tapped on the white star to bookmark the page. I've checked its title and it seems that, beside the missed place punctuation, "Yahoo" is written only with one "o". Is this related to this issue?

--
Build id : Mozilla/5.0 (Android;Linux armv7l;rv:6.0)Gecko/20110729
Firefox/6.0 Fennec/6.0
Device: HTC Desire Z
OS: Android 2.2.1

Comment 12

[Anas Husseini [:linostar]]

(In reply to comment #11)
> Created attachment 549743 [details]
> Screenshot
> 
> I've browsed to www.yahoo.com and I've tapped on the white star to bookmark
> the page. I've checked its title and it seems that, beside the missed place
> punctuation, "Yahoo" is written only with one "o". Is this related to this
> issue?

No, that's bug 653688.

Comment 13

[Anas Husseini [:linostar]]

Attachment: patch v1.1 (with commit message)

Comment 14

[Justin Wood (:Callek)]

$ hg qpush -v
applying 605342
patching file mobile/themes/core/browser.css
Hunk #1 FAILED at 216
1 out of 1 hunks FAILED -- saving rejects to file mobile/themes/core/browser.css
.rej
patch failed to apply
mobile/themes/core/browser.css
patch failed, rejects left in working dir
errors during apply, please fix and refresh 605342

Please refresh this patch.

Comment 15

[BMO Automation]

Closing all opened bug in a graveyard component