Closed Bug 605351 Opened 9 years ago Closed 9 years ago

fix and re-enable browser_webconsole_bug_593003_iframe_wrong_hud.js

Categories

(DevTools :: General, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rcampbell, Assigned: msucan)

References

Details

(Whiteboard: [patchclean:1021] [console-1])

Attachments

(1 file)

This test was disabled around the same time as the compartments landing, but I think was shut off separately from the original tests. We should get it fixed up and operational again.

Followup from bug 604536.
Blocks: devtools4b8
Proposed test fix. All tests pass in debug and opt builds (Linux).
Assignee: nobody → mihai.sucan
Status: NEW → ASSIGNED
Attachment #485001 - Flags: feedback?(ddahl)
Whiteboard: [patchclean:1021]
Comment on attachment 485001 [details] [diff] [review]
proposed test fix

Is this patch missing the actual test bits where we verify things? It looks like it just opens tabs and closes them.
Attachment #485001 - Flags: feedback?(ddahl) → feedback-
(In reply to comment #2)
> Comment on attachment 485001 [details] [diff] [review]
> proposed test fix
> 
> Is this patch missing the actual test bits where we verify things? It looks
> like it just opens tabs and closes them.

This patch fixes the test. Indeed, in the patch the actual tests are not visible, however please apply the patch and see the resulting mochitest file. It opens two tabs and it tests if the iframe network request is recorded in the correct tab.
mass change: filter on PRIORITYSETTING
Blocks: devtools4
Priority: -- → P3
Whiteboard: [patchclean:1021] → [patchclean:1021] [console-1]
This bug is already fixed, but I don't know by what other bug.
It's unfortunate that we don't know when this was fixed, but there's no point leaving this bug open if we know that it is fixed.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.