605364 - Addon manager seems to think that all addons are restartless

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux i686; rv:2.0b8pre) Gecko/20101013 Firefox/4.0b8pre SeaMonkey/2.1b2pre - Build ID: 20101013012015

* When I upgrade an addon, the new version appears immediately as soon as I refresh the EM tab (e.g. by switching back and forth between "Appearance" and "Extensions"). But this does not mean that I get the updated functionality without restarting (e.g. Adblock Plus, Flagfox).
* When I click [Enable] the button immediately turns to [Disable]
* No indication that "something will happen" after restart, no "Undo" link
* When I [Enable] a theme, it is applied immediately, even if "Edit => Preferences => Debug => Miscellaneous => [ ] Enable Dynamic Skin Switching" is UNticked. However, when switching from "SeaMonkey default" to e.g. "EarlyBlue", the default theme's toolbar icons remain displayed on each toolbar until I change that toolbar icon size via its context menu.
* If the "Available Updates" pane is open when I "Install" an addon from a local file, that addon will temporarily be listed there. It disappears if I select "Extensions" and come back.
* If I install or upgrade a (non-restartless) addon by clicking on a link in a web page, it doesn't even appear under "Available upgrades"
* AFAICT, there's no way I can get an "Update" button or link in the EM.

Note: I have selected "Reset all addons to update manually" in the EM and I have unticked "Edit => Preferences => Advanced :: Software Installation => Updates => Automatically check for updates to [ ] Installed Add-ons". Don't know if relevant.

Comment 1

[Tony Mechelynck [:tonymec]]

oops... there's no way I can get a "Restart" button...

Comment 2

[Dave Townsend [:mossop]]

Are you using the default theme? Have you tested this with a clean profile and just a single simple add-on?

Comment 3

[Tony Mechelynck [:tonymec]]

(In reply to comment #2)
> Are you using the default theme? Have you tested this with a clean profile and
> just a single simple add-on?

A clean profile, not yet, but I'm going to. Stay tuned.

Comment 4

[Tony Mechelynck [:tonymec]]

(In reply to comment #3)
> (In reply to comment #2)
> > Are you using the default theme? Have you tested this with a clean profile and
> > just a single simple add-on?
> 
> A clean profile, not yet, but I'm going to. Stay tuned.

All right, it doesn't happen in a clean profile, when enabling/disabling the built-in extensions & themes, or installing Adblock Plus: seems I jumped the gun once again. Now I'll have to disable my addons from the "Recently updated" list, starting about when I think that the "strange behaviour" appeared.

Comment 5

[Tony Mechelynck [:tonymec]]

Hard to tell what happens in Safe Mode because of the way everything is (disabled) there. I think I see the same symptoms (except of course restartless skin switching) but maybe they are normal in this mode.

Comment 6

[Tony Mechelynck [:tonymec]]

I noticed yesterday that selecting a different ("heavyweight") theme applied it immediately (which is buggy: some icons from before the change are left over in the chrome) -- and yet extensions.dss.enabled is at its default (false) value. That was on yesterday's nightly, but I suppose nothing changed today: my current (today's) nightly is

Mozilla/5.0 (X11; Linux i686; rv:2.0b9pre) Gecko/20101229 Firefox/4.0b9pre SeaMonkey/2.1b2pre
ID:20101229003001

Comment 7

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux i686; rv:2.0b10pre) Gecko/20110112 Firefox/4.0b10pre SeaMonkey/2.1b2pre ID:20110112003003

Problem "seems" to be gone, either fixed by the fix to some other bug, or because I updated my theme (EarlyBlue) to the latest unreleased changeset of its git development server http://git-public.kairo.at/?p=themes.git;a=summary (well, almost: that was the changeset from 2010-01-09 19:29:27 UTC and there's been one changeset since then, but "Firefox-related"). I haven't yet conducted exhaustive tests though, so I'll let this "bake" some more before declaring that the bug is gone and does not reappear.