605384 - remote android file picker

Status: RESOLVED DUPLICATE of bug 594368

(Core Graveyard :: Widget: Android, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

It currently only works in the chrome process because the android bridge is only available in the chrome process

Comment 1

[Doug Turner (:dougt)]

Comment on attachment 484242 [details] [diff] [review]
patch


>+bool
>+ContentParent::RecvShowFilePicker(nsString* aFilePath) 
>+{
>+#ifdef ANDROID
>+    AndroidBridge::Bridge()->ShowFilePicker(*aFilePath);
>+#endif
>+    return true;
>+}

should non-android ever call this? NS_RUNTIMEABORT

>-    mozilla::AndroidBridge::Bridge()->ShowFilePicker(filePath);
>+    if (mozilla::AndroidBridge::Bridge())
>+        mozilla::AndroidBridge::Bridge()->ShowFilePicker(filePath);
>+    else
>+        mozilla::dom::ContentChild::GetSingleton()->SendShowFilePicker(&filePath);
>+


Shouldn't the bridge hide this nasty branch?

This doesn't do everything our filepickers can do.  For example, multiple files..  Have you looked at bug 594368 (even has a patch!).  Maybe get that cleaned up and land that instead?