Last Comment Bug 605425 - Non-english templates are no longer precompiled by checksetup
: Non-english templates are no longer precompiled by checksetup
Status: RESOLVED FIXED
: regression
Product: Bugzilla
Classification: Server Software
Component: Installation & Upgrading (show other bugs)
: 3.6.2
: All All
: -- normal (vote)
: Bugzilla 3.6
Assigned To: Frédéric Buclin
: default-qa
:
Mentors:
Depends on: 430012
Blocks:
  Show dependency treegraph
 
Reported: 2010-10-19 03:43 PDT by Frédéric Buclin
Modified: 2010-10-20 16:15 PDT (History)
1 user (show)
mkanat: approval+
mkanat: approval4.0+
mkanat: blocking4.0+
mkanat: approval3.6+
mkanat: blocking3.6.3-
See Also:
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch, v1 (1.76 KB, patch)
2010-10-20 11:21 PDT, Frédéric Buclin
mkanat: review+
Details | Diff | Splinter Review
patch for 3.6, v1 (1.52 KB, patch)
2010-10-20 16:10 PDT, Frédéric Buclin
mkanat: review+
Details | Diff | Splinter Review

Description Frédéric Buclin 2010-10-19 03:43:15 PDT
This is a regression due to bug 430012: checksetup.pl no longer precompiles templates except english and your local language. That's because precompile_templates() calls template_include_path(), which itself calls include_languages() which limits the list of languages to the ones you use. This means that all my installations with several l10n templates on them have no precompiled l10n templates, which makes Bugzilla slower the first time you visit them, but also all the permissions are wrong because instead of lpsolit:apache, they all have apache:apache, which prevents me from deleting them (data/deleteme/ becomes larger every time I run checksetup.pl, with no way to delete it).
Comment 1 Max Kanat-Alexander 2010-10-19 11:55:25 PDT
  Hmm. Yes, I suppose only the templates that are in the template search patch will be recompiled. I bet it has more to do with localizing checksetup than it does with the template include changes, but they're both probably related.

  We'll see how involved the fix is. If it's small, we'll take it for 3.6.x, but I don't want to block 3.6.x on it.
Comment 2 Frédéric Buclin 2010-10-20 11:21:22 PDT
Created attachment 484740 [details] [diff] [review]
patch, v1
Comment 3 Max Kanat-Alexander 2010-10-20 15:39:32 PDT
Comment on attachment 484740 [details] [diff] [review]
patch, v1

Oh, that's actually a pretty good idea! :-) Wow, super-simple fix, and it looks like it will work just fine. :-) Thanks!
Comment 4 Frédéric Buclin 2010-10-20 16:10:53 PDT
Created attachment 484868 [details] [diff] [review]
patch for 3.6, v1

The previous patch doesn't apply cleanly for 3.6.
Comment 5 Frédéric Buclin 2010-10-20 16:15:03 PDT
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Template.pm
modified Bugzilla/Install/Util.pm
Committed revision 7553.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.0/
modified Bugzilla/Template.pm
modified Bugzilla/Install/Util.pm
Committed revision 7448.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/3.6/
modified Bugzilla/Template.pm
modified Bugzilla/Install/Util.pm
Committed revision 7193.

Note You need to log in before you can comment on or make changes to this bug.