605425 - Non-english templates are no longer precompiled by checksetup

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, defect)

Description

[Frédéric Buclin]

This is a regression due to bug 430012: checksetup.pl no longer precompiles templates except english and your local language. That's because precompile_templates() calls template_include_path(), which itself calls include_languages() which limits the list of languages to the ones you use. This means that all my installations with several l10n templates on them have no precompiled l10n templates, which makes Bugzilla slower the first time you visit them, but also all the permissions are wrong because instead of lpsolit:apache, they all have apache:apache, which prevents me from deleting them (data/deleteme/ becomes larger every time I run checksetup.pl, with no way to delete it).

Comment 1

[Max Kanat-Alexander]

  Hmm. Yes, I suppose only the templates that are in the template search patch will be recompiled. I bet it has more to do with localizing checksetup than it does with the template include changes, but they're both probably related.

  We'll see how involved the fix is. If it's small, we'll take it for 3.6.x, but I don't want to block 3.6.x on it.

Comment 2

[Frédéric Buclin]

Attachment: patch, v1

Comment 3

[Max Kanat-Alexander]

Comment on attachment 484740 [details] [diff] [review]
patch, v1

Oh, that's actually a pretty good idea! :-) Wow, super-simple fix, and it looks like it will work just fine. :-) Thanks!

Comment 4

[Frédéric Buclin]

Attachment: patch for 3.6, v1

The previous patch doesn't apply cleanly for 3.6.

Comment 5

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified Bugzilla/Template.pm
modified Bugzilla/Install/Util.pm
Committed revision 7553.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified Bugzilla/Template.pm
modified Bugzilla/Install/Util.pm
Committed revision 7448.

Committing to: bzr+ssh://[e-mail]/bugzilla/3.6/
modified Bugzilla/Template.pm
modified Bugzilla/Install/Util.pm
Committed revision 7193.