The default bug view has changed. See this FAQ.

Implement FpReg move on icc or fcc for asm_cmov()

RESOLVED FIXED

Status

Core Graveyard
Nanojit
RESOLVED FIXED
7 years ago
3 years ago

People

(Reporter: Ginn Chen, Assigned: Ginn Chen)

Tracking

Trunk
Sun
OpenSolaris
Bug Flags:
flashplayer-qrb +
flashplayer-bug -

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: fixed-in-nanojit, fixed-in-tamarin)

Attachments

(1 attachment)

11.16 KB, patch
William Maddox
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Updated

7 years ago
Summary: Implement FpReg move on icc for asm_cmov() → Implement FpReg move on icc or fcc for asm_cmov()
(Assignee)

Comment 1

7 years ago
Created attachment 485260 [details] [diff] [review]
patch
Attachment #485260 - Flags: review?(wmaddox)

Updated

7 years ago
Attachment #485260 - Flags: review?(wmaddox) → review+

Comment 2

7 years ago
R+

nits:

    inline void Assembler::FMOVDcc
        (Register rs, int32_t opt_cc, Register rd, int32_t cond, const char *opcode) {

- Don't break the line before the argument list -- it's not excessively long by the standards of the rest of the file.

- Our preferred convention, per discussion some months ago, is that the * should associate with the type, not the variable, e.g., char* rather than char *.  The code elsewhere in this file isn't consistent, however, so if you're just going with the immediate neighborhood, that's ok.
(Assignee)

Comment 3

7 years ago
http://hg.mozilla.org/projects/nanojit-central/rev/ce344dfb7fcb

Fixed the line break.
Leave the "char *opcode" for future fixes.
Whiteboard: fixed-in-nanojit

Comment 4

7 years ago
http://hg.mozilla.org/tamarin-redux/rev/e952f880d3f6
Whiteboard: fixed-in-nanojit → fixed-in-nanojit, fixed-in-tamarin

Comment 5

6 years ago
Can this be closed?  Waiting to land in TM?
Flags: flashplayer-qrb+
Flags: flashplayer-bug-

Updated

6 years ago
Blocks: 607452
(Assignee)

Comment 6

6 years ago
this one is already landed on MC.

http://hg.mozilla.org/mozilla-central/rev/16c78e2e5c30
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Component: Nanojit → Nanojit
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.