605427 - Implement FpReg move on icc or fcc for asm_cmov()

Status: RESOLVED FIXED

(Core Graveyard :: Nanojit, defect)

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[William Maddox]

R+

nits:

    inline void Assembler::FMOVDcc
        (Register rs, int32_t opt_cc, Register rd, int32_t cond, const char *opcode) {

- Don't break the line before the argument list -- it's not excessively long by the standards of the rest of the file.

- Our preferred convention, per discussion some months ago, is that the * should associate with the type, not the variable, e.g., char* rather than char *.  The code elsewhere in this file isn't consistent, however, so if you're just going with the immediate neighborhood, that's ok.

Comment 3

[Ginn Chen]

http://hg.mozilla.org/projects/nanojit-central/rev/ce344dfb7fcb

Fixed the line break.
Leave the "char *opcode" for future fixes.

Comment 4

[Rick Reitmaier]

http://hg.mozilla.org/tamarin-redux/rev/e952f880d3f6

Comment 5

[Dan Smith]

Can this be closed?  Waiting to land in TM?

Comment 6

[Ginn Chen]

this one is already landed on MC.

http://hg.mozilla.org/mozilla-central/rev/16c78e2e5c30