605466 - Implement new spec limits for formatting element growth

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect, P2)

Description

[Henri Sivonen (:hsivonen)]

The spec recently got hard-coded limits that avoid excessive growth of the number of formatting element nodes in the DOM:
http://html5.org/tools/web-apps-tracker?from=5637&to=5638
http://html5.org/tools/web-apps-tracker?from=5641&to=5642

These limits should be implemented in Gecko.

Comment 1

[Henri Sivonen (:hsivonen)]

Attachment: Implementation without a test

Comment 2

[Henri Sivonen (:hsivonen)]

Nominating as a blocker, since this helps deal with DoS-by-author-incompetence.

Comment 3

[Henri Sivonen (:hsivonen)]

Attachment: Implementation with tests

The new MathML-related test failure is a side effect of refreshing the html5lib test suite to what the upstream has. I filed a new bug about the new test failure. It has nothing to do with the code changes here.

Comment 4

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 485699 [details] [diff] [review]
Implementation with tests

rs=me

Comment 5

[Henri Sivonen (:hsivonen)]

http://hg.mozilla.org/mozilla-central/rev/308dfe76b260

Comment 6

[Johnathan Nightingale [:johnath]]

This is a hardblocker, but a bugzilla caching issue makes it keep coming back up in searches incorrectly. Clearing the whiteboard.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

** PRODUCT DRIVERS PLEASE NOTE **

This bug is one of 19 being moved from blocking2.0:betaN+ to blocking2.0:- as we reached the endgame of Firefox 4. The rationale for the move is:

 - the bug had been identified as a "soft" blocker which could be fixed in some follow up release
 - the bug had been identified as one requiring beta coverage, thus is not appropriate for a ".x" stability & security release

The owner of the bug may wish to renominate for .x consideration.

Comment 8

[Henri Sivonen (:hsivonen)]

Denominating, because this bug has landed already in November and keeps popping up on blocker queries due to a Bugzilla bug.