Closed Bug 605466 Opened 10 years ago Closed 10 years ago

Implement new spec limits for formatting element growth

Categories

(Core :: DOM: HTML Parser, defect, P2)

Product:
Core
Component:
DOM: HTML Parser
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: hsivonen, Assigned: hsivonen)

Details

(Whiteboard: [already landed, shows up on blocker queries due to Bugzilla bug])

Attachments

(1 file, 1 obsolete file)

Implementation with tests
28.97 KB, patch
sicking
: review+
Details | Diff | Splinter Review 
The spec recently got hard-coded limits that avoid excessive growth of the number of formatting element nodes in the DOM:
http://html5.org/tools/web-apps-tracker?from=5637&to=5638
http://html5.org/tools/web-apps-tracker?from=5641&to=5642

These limits should be implemented in Gecko.
Attached patch Implementation without a test (obsolete) — — Splinter Review
Assignee: nobody → hsivonen
Status: NEW → ASSIGNED
Nominating as a blocker, since this helps deal with DoS-by-author-incompetence.
blocking2.0: --- → ?
Priority: -- → P2
blocking2.0: ? → betaN+
The new MathML-related test failure is a side effect of refreshing the html5lib test suite to what the upstream has. I filed a new bug about the new test failure. It has nothing to do with the code changes here.
Attachment #484308 - Attachment is obsolete: true
Attachment #485699 - Flags: review?(jonas)
Comment on attachment 485699 [details] [diff] [review]
Implementation with tests

rs=me
Attachment #485699 - Flags: review?(jonas) → review+
http://hg.mozilla.org/mozilla-central/rev/308dfe76b260
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [hardblocker]
This is a hardblocker, but a bugzilla caching issue makes it keep coming back up in searches incorrectly. Clearing the whiteboard.
Whiteboard: [hardblocker]
** PRODUCT DRIVERS PLEASE NOTE **

This bug is one of 19 being moved from blocking2.0:betaN+ to blocking2.0:- as we reached the endgame of Firefox 4. The rationale for the move is:

 - the bug had been identified as a "soft" blocker which could be fixed in some follow up release
 - the bug had been identified as one requiring beta coverage, thus is not appropriate for a ".x" stability & security release

The owner of the bug may wish to renominate for .x consideration.
blocking2.0: betaN+ → .x+
Denominating, because this bug has landed already in November and keeps popping up on blocker queries due to a Bugzilla bug.
blocking2.0: .x+ → ---
Whiteboard: [already landed, shows up on blocker queries due to Bugzilla bug]
You need to log in before you can comment on or make changes to this bug.