Closed Bug 605527 Opened 10 years ago Closed 10 years ago

Move feedback.dtd out of app/profile for localization

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: vingtetun, Assigned: vingtetun)

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
Pike told me that there is no way to translate feedback.dtd right now because it is situated into app/profile/extensions/feedback@mozilla.com.

He suggests we move it to locales/en-US since this is what Firefox does.

I wonder if we want to include feedback.dtd conditionally?
Attachment #484373 - Flags: review?(mark.finkle)
Doing it conditionally just causes trouble for add-on compatibility at some point down the road. For fx, we just take it and be done with it.
Comment on attachment 484373 [details] [diff] [review]
Patch

Not the most elegant solution, but I guess we need to live with it. Couldn't the locales override feedback.dtd?

r+ for now so we get it localized
Attachment #484373 - Flags: review?(mark.finkle) → review+
filed bug 606038.  Not sure if it's related?
We could remove 
locale  feedback en-US       locale/en-US/
in
feedback\@mobile.mozilla.org/chrome.manifest
Verified by looking at the code.
Status: RESOLVED → VERIFIED
bugspam
Assignee: nobody → 21
You need to log in before you can comment on or make changes to this bug.