605527 - Move feedback.dtd out of app/profile for localization

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: Patch

Pike told me that there is no way to translate feedback.dtd right now because it is situated into app/profile/extensions/[e-mail].

He suggests we move it to locales/en-US since this is what Firefox does.

I wonder if we want to include feedback.dtd conditionally?

Comment 1

[Axel Hecht [:Pike]]

Doing it conditionally just causes trouble for add-on compatibility at some point down the road. For fx, we just take it and be done with it.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 484373 [details] [diff] [review]
Patch

Not the most elegant solution, but I guess we need to live with it. Couldn't the locales override feedback.dtd?

r+ for now so we get it localized

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

http://hg.mozilla.org/mobile-browser/rev/d317501e4f4c
http://hg.mozilla.org/mobile-browser/rev/f3d0ab017f1a

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

filed bug 606038.  Not sure if it's related?

Comment 5

[Axel Hecht [:Pike]]

We could remove 
locale  feedback en-US       locale/en-US/
in
feedback\@mobile.mozilla.org/chrome.manifest

Comment 6

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified by looking at the code.

Comment 7

[Dão Gottwald [:dao]]

bugspam