Closed
Bug 605565
Opened 15 years ago
Closed 15 years ago
Re-enable JSterm helper tests
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rcampbell, Assigned: rcampbell)
References
Details
Attachments
(1 file)
|
5.53 KB,
patch
|
Gavin
:
review+
|
Details | Diff | Splinter Review |
During a preliminary once-over of bug 599940, gavin discovered that the jsterm helper tests were not ported over during the deconstruction of HUDServiceTestsAll.
see:
http://hg.mozilla.org/mozilla-central/rev/6160fe29dd37#l3.7
This bug is to add them back.
|
Assignee | |
Comment 1•15 years ago
|
||
|
||
Comment 2•15 years ago
|
||
Comment on attachment 484421 [details] [diff] [review]
[checked-in] webconsole_jsterm
Seems like you could add a checkResult() helper that does the querySelector/is() checks:
function checkResult(msg, desc, lines) {
let labels = jsterm.outputNode.querySelectorAll(".jsterm-output-line");
is(labels.length, lines, "correct number of results shown for " + desc);
is(labels[lines-1].textContent.trim(), msg, "correct message shown for " + desc);
}
Attachment #484421 -
Flags: review?(gavin.sharp) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Comment on attachment 484421 [details] [diff] [review]
[checked-in] webconsole_jsterm
http://hg.mozilla.org/mozilla-central/rev/189f8ed29460
Attachment #484421 -
Attachment description: webconsole_jsterm → [checked-in] webconsole_jsterm
|
|
Assignee | |
Updated•15 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•