605565 - Re-enable JSterm helper tests

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Rob Campbell [:rc] (:robcee)]

During a preliminary once-over of bug 599940, gavin discovered that the jsterm helper tests were not ported over during the deconstruction of HUDServiceTestsAll.

see:
http://hg.mozilla.org/mozilla-central/rev/6160fe29dd37#l3.7

This bug is to add them back.

Comment 1

[Rob Campbell [:rc] (:robcee)]

Attachment: [checked-in] webconsole_jsterm

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 484421 [details] [diff] [review]
[checked-in] webconsole_jsterm

Seems like you could add a checkResult() helper that does the querySelector/is() checks:

function checkResult(msg, desc, lines) {
  let labels = jsterm.outputNode.querySelectorAll(".jsterm-output-line");
  is(labels.length, lines, "correct number of results shown for " + desc);
  is(labels[lines-1].textContent.trim(), msg, "correct message shown for " + desc);
}

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 484421 [details] [diff] [review]
[checked-in] webconsole_jsterm

http://hg.mozilla.org/mozilla-central/rev/189f8ed29460