Closed Bug 605626 Opened 12 years ago Closed 12 years ago

"ASSERTION: viewBox width must be greater than zero"

Categories

(Core :: SVG, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: jruderman, Assigned: longsonr)

References

Details

(Keywords: assertion, testcase)

Attachments

(2 files, 2 obsolete files)

Attached image testcase
###!!! ASSERTION: viewBox width must be greater than zero!: 'aViewboxWidth > 0', file layout/svg/base/src/nsSVGUtils.cpp, line 816

###!!! ASSERTION: viewBox height must be greater than zero!: 'aViewboxHeight > 0', file layout/svg/base/src/nsSVGUtils.cpp, line 817
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → longsonr
Attachment #485594 - Flags: review?(dholbert)
Doesn't nsSVGImageFrame::GetFrameForPoint need an early return too, for zero image-native-size?
Attached patch address review comment (obsolete) — Splinter Review
Attachment #485594 - Attachment is obsolete: true
Attachment #485603 - Flags: review?(dholbert)
Attachment #485594 - Flags: review?(dholbert)
(In reply to comment #2)
> Doesn't nsSVGImageFrame::GetFrameForPoint need an early return too, for zero
> image-native-size?

yes it does :-)
Attachment #485603 - Flags: review?(dholbert) → review+
Comment on attachment 485603 [details] [diff] [review]
address review comment

Stops us asserting with images that can't be drawn. Low risk.
Attachment #485603 - Flags: approval2.0?
Attachment #485603 - Attachment is obsolete: true
Keywords: checkin-needed
Whiteboard: [c-n: after 2.0b7 freeze]
http://hg.mozilla.org/mozilla-central/rev/459b7ba2ab70
Status: NEW → RESOLVED
Closed: 12 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: after 2.0b7 freeze]
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.