"ASSERTION: viewBox width must be greater than zero"

RESOLVED FIXED in mozilla2.0b8

Status

()

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: jruderman, Assigned: longsonr)

Tracking

(Blocks: 1 bug, {assertion, testcase})

Trunk
mozilla2.0b8
x86
Mac OS X
assertion, testcase
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

(Reporter)

Description

8 years ago
Created attachment 484493 [details]
testcase

###!!! ASSERTION: viewBox width must be greater than zero!: 'aViewboxWidth > 0', file layout/svg/base/src/nsSVGUtils.cpp, line 816

###!!! ASSERTION: viewBox height must be greater than zero!: 'aViewboxHeight > 0', file layout/svg/base/src/nsSVGUtils.cpp, line 817
(Assignee)

Comment 1

8 years ago
Created attachment 485594 [details] [diff] [review]
patch
Assignee: nobody → longsonr
Attachment #485594 - Flags: review?(dholbert)
Doesn't nsSVGImageFrame::GetFrameForPoint need an early return too, for zero image-native-size?
(Assignee)

Comment 3

8 years ago
Created attachment 485603 [details] [diff] [review]
address review comment
Attachment #485594 - Attachment is obsolete: true
Attachment #485603 - Flags: review?(dholbert)
Attachment #485594 - Flags: review?(dholbert)
(Assignee)

Comment 4

8 years ago
(In reply to comment #2)
> Doesn't nsSVGImageFrame::GetFrameForPoint need an early return too, for zero
> image-native-size?

yes it does :-)
Attachment #485603 - Flags: review?(dholbert) → review+
(Assignee)

Comment 5

8 years ago
Comment on attachment 485603 [details] [diff] [review]
address review comment

Stops us asserting with images that can't be drawn. Low risk.
Attachment #485603 - Flags: approval2.0?
(Assignee)

Comment 6

8 years ago
Created attachment 486018 [details] [diff] [review]
hg changeset patch
Attachment #485603 - Attachment is obsolete: true
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
(Assignee)

Updated

8 years ago
Whiteboard: [c-n: after 2.0b7 freeze]
http://hg.mozilla.org/mozilla-central/rev/459b7ba2ab70
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: after 2.0b7 freeze]
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.