Minor changes to test framework for ATS test export.

VERIFIED FIXED

Status

Tamarin
Tools
VERIFIED FIXED
8 years ago
7 years ago

People

(Reporter: Chris Peyer, Assigned: Chris Peyer)

Tracking

(Blocks: 1 bug)

Details

Attachments

(1 attachment)

(Assignee)

Description

8 years ago
- runtests needs to be run with only 1 thread when export ATS swfs
- runtests doesn't always read in the testconfig ats_skip directive
- update testconfig for new tests
- rename tests that start with numbers: ATS needs tests to start with letters
- shell.as needs to have the print function defined
(Assignee)

Updated

7 years ago
Blocks: 607714
(Assignee)

Comment 1

7 years ago
Created attachment 487026 [details] [diff] [review]
ats changes

Hodgepodge of fixes for issues listed above.  Also has whitespace fixes as I mistakenly had my editor set to clear all trailing whitespace.
Assignee: nobody → cpeyer
Status: NEW → ASSIGNED
Attachment #487026 - Flags: review?(brbaker)

Comment 2

7 years ago
Comment on attachment 487026 [details] [diff] [review]
ats changes

r+ with nits

Please do not commmit the whitespace change and your code change in one patch. Whitespace changes should be committed on there own and not with other code changes. I end up having to parse the entire patch (90% whitespace change) just to see what I should be ignoring as not a code change.

Create and reference a bug (watson or bugzilla) in the testconfig where tests are being skipped in ATS because there is currently no solution for testing versioning in the player. Also please change "soln" to "solution" :)
Attachment #487026 - Flags: review?(brbaker) → review+
(Assignee)

Comment 3

7 years ago
Pushed to redux with suggested changes:

http://hg.mozilla.org/tamarin-redux/rev/612dfaf51cce
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.