DOS line endings on config_win32.h

RESOLVED INVALID

Status

()

Core
Audio/Video
RESOLVED INVALID
7 years ago
7 years ago

People

(Reporter: Jeff Beckley, Unassigned)

Tracking

1.9.2 Branch
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Created attachment 484583 [details]
Convert DOS to Unix line endings

In changeset 32222:37f2a93fbe7e the file media/liboggz/include/oggz/config_win32.h was checked in with DOS line endings.

Attached is a patch to make it use Unix line endings.
(Reporter)

Updated

7 years ago
Attachment #484583 - Flags: superreview?(chris.double)
Attachment #484583 - Flags: review?(chris)
Comment on attachment 484583 [details]
Convert DOS to Unix line endings

The file which media/liboggz/include/oggz/config_win32.h is copied from upstream in liboggz (liboggz/win32/config.h) has DOS style line endings. So we just faithfully checked in the same DOS style line endings.

What benefit do we get by deviating from upstream and changing the line endings of this file?

If you want to make this change, you might be best to file a bug upstream in trac.xiph.org and submit your patch there, or email it to the ogg-dev mailing list, and we'll eventually get this change next time we update our copy of liboggz.
Attachment #484583 - Flags: review?(chris) → review-

Comment 2

7 years ago
Comment on attachment 484583 [details]
Convert DOS to Unix line endings

I agree with cpearce that the best way of dealing with this would be to get the patch accepted upstream first. If we take a patch to convert DOS line endings and later need to merge some upstream changes it can cause merge issues.
Attachment #484583 - Flags: superreview?(chris.double) → superreview-
(Reporter)

Comment 3

7 years ago
OK, I will submit a bug to liboggz.  When I browsed the liboggz source I didn't see a corresponding config_win32.h file so I assumed that it was something that Mozilla had added.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INVALID
(Reporter)

Comment 4

7 years ago
Bug created against liboggz is https://trac.annodex.net/ticket/501
You need to log in before you can comment on or make changes to this bug.