605813 - Re-enable test_taskbar_progress.xul on Windows

Status: RESOLVED FIXED

(Core :: Widget: Win32, defect)

Description

[Rain [:rain1] (inactive)]

Via bug 548763 comment 30, and I can reproduce locally, the test fails with 

Error: uncaught exception: [Exception... "Component returned failure code:
0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIWinTaskbar.getTaskbarProgress]" 
nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
chrome://mochikit/content/chrome/widget/tests/taskbar_progress.xul :: loaded ::
line 48"  data: no]

The reason we haven't caught it yet is because we weren't running the test at all: see bug 605812.

Comment 1

[Joe Drew (not getting mail)]

Well, you wrote it :)

Is a bad enough failure that it indicates something is seriously wrong that we shouldn't release without?

Comment 2

[Rain [:rain1] (inactive)]

(In reply to comment #1)
> Well, you wrote it :)

I only wrote the patch, not the test. Felipe wrote the test :)

Comment 3

[Rain [:rain1] (inactive)]

(In reply to comment #1)
> Is a bad enough failure that it indicates something is seriously wrong that we
> shouldn't release without?

I don't think so -- taskbar progress definitely still works.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

I didn't write this test! I only wrote the front-end tests.

I'll take a look later today, I guess this could be one of the inner/outer window changes from brain transplants.

Comment 5

[Rain [:rain1] (inactive)]

Sorry, jmathies did.

Comment 6

[Jim Mathies [:jimm]]

(In reply to comment #5)
> Sorry, jmathies did.

I think rob put these together, although I probably r+'m.

Comment 7

[Jim Mathies [:jimm]]

Regardless of who wrote them, who wants to look into this?

Comment 8

[Joe Drew (not getting mail)]

Felipe! He said so in comment 4.

Comment 9

[Joe Drew (not getting mail)]

Not blocking based on comment 3, but I'll listen to arguments otherwise, and I'd take a patch.

Comment 10

[Rob Arnold [:robarnold]]

I wrote the previews one but not the progress ones. What's the error on the previews one? I can help fix that for sure.

My wild guess on the progress error is that we're giving it the wrong docShell. We should take the one from the appropriate toplevel XUL window.

Comment 11

[Rain [:rain1] (inactive)]

(In reply to comment #10)
> I wrote the previews one but not the progress ones. What's the error on the
> previews one? I can help fix that for sure.

It's the same error for both previews and progress -- failure in getTaskbarState.

Comment 12

[:Felipe Gomes (needinfo for replies!)]

It seems to be a regression from 130078:

  HWND toplevelHWND = ::GetAncestor(GetHWNDFromDocShell(shell), GA_ROOT);

  if (!toplevelHWND)
    return NS_ERROR_INVALID_ARG;

Comment 13

[:Felipe Gomes (needinfo for replies!)]

What fails is GetHWNDFromDocShell, as the docshell passed (gBrowser.docShell) is the content's docshell, which no longer have a native window.

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/80ff21ac7b5c

Comment 15

[:Felipe Gomes (needinfo for replies!)]

I fixed test_taskbar_progress and re-enabled it on Windows. It worked well on try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=00930a723e66

I didn't touch test_taskbar_previews.xul because that might significantly change anyway with the e10s work in bug 1096804, so it's better to leave it to that bug.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/80ff21ac7b5c