Use balloon tips to notify new messages

RESOLVED FIXED in Thunderbird 3.3a2

Status

MailNews Core
Backend
--
enhancement
RESOLVED FIXED
7 years ago
4 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 3.3a2
All
Windows XP
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Since we switched to supporting Windows 2000 or later, we can actually use the balloon notification instead of the pop-up alert.
(Assignee)

Comment 1

7 years ago
Created attachment 484823 [details] [diff] [review]
Proof of concept

I don't know whether Thunderbird would find this useful or not, but it affects a core file, so requesting sr.
Attachment #484823 - Flags: superreview?(bienvenu)

Comment 2

7 years ago
Comment on attachment 484823 [details] [diff] [review]
Proof of concept

I don't know if Thunderbird is interested in this - I'll have to try it out in SM.
Attachment #484823 - Flags: superreview?(bienvenu) → superreview+
(Assignee)

Comment 3

7 years ago
Created attachment 488853 [details] [diff] [review]
Untested Thunderbird changes

I don't actually know whether this compiles for Thunderbird.

To test this you will need to add the balloon tip preference via config editor.
Attachment #488853 - Flags: superreview?(bienvenu)

Comment 4

7 years ago
Comment on attachment 488853 [details] [diff] [review]
Untested Thunderbird changes

thx for the patch, I got this to work for TB. I'll attach a patch that compiles in a minute...
Attachment #488853 - Flags: superreview?(bienvenu)

Comment 5

7 years ago
Created attachment 488879 [details] [diff] [review]
get to compile in TB

This is pretty much a UI call - it's nice to use the nice OS  widget, but our new mail alert has so much more info (message subject, sender, snippet, and each message is clickable) that I'm pretty sure we wouldn't default to this. I suppose one option is to use the balloon if the user turns off message preview text, subject, and sender.
Attachment #488853 - Attachment is obsolete: true
Attachment #488879 - Flags: ui-review?(clarkbw)
(Assignee)

Comment 6

7 years ago
Comment on attachment 488879 [details] [diff] [review]
get to compile in TB

>-#ifdef MOZ_THUNDERBIRD
>-  nsresult ShowNewAlertNotification(PRBool aUserInitiated);
>+#ifndef MOZ_THUNDERBIRD
>+  nsresult ShowAlertMessage(const nsString& aAlertTitle, const nsString& aAlertText, const nsACString& aFolderURI);
>+#else
>+  nsresult ShowNewAlertNotification(PRBool aUserInitiated, const nsString& aAlertTitle, const nsString& aAlertText);
> #endif
>-
Whoops, I didn't realise that your method needed to be public. Might as well just update the existing lines in place in that case. Or maybe use this:
> #ifdef MOZ_THUNDERBIRD
>-  nsresult ShowNewAlertNotification(PRBool aUserInitiated);
>+  nsresult ShowNewAlertNotification(PRBool aUserInitiated, const nsString& aAlertTitle, const nsString& aAlertText);
>+#else
>+  nsresult ShowAlertMessage(const nsString& aAlertTitle, const nsString& aAlertText, const nsACString& aFolderURI);
> #endif
Does anyone happen to have a screenshot of this?  I don't have a windows build available right now.  Thanks.
Hardware: x86 → All
Comment on attachment 488879 [details] [diff] [review]
get to compile in TB

looks pretty cool.  not sure where the text I saw in the screenshot came from but 

- Screenshot -

*Google*
has 2 new messages

I feel like we should change the secondary text to: "2 new messages" for ease of translation and the 'has' reads better overall but I think it distracts from the message a little.  Sound good?

ui-r+ otherwise
Attachment #488879 - Flags: ui-review?(clarkbw) → ui-review+
(Assignee)

Comment 9

7 years ago
Created attachment 491612 [details] [diff] [review]
Tweaked patch

Tweaked the ifdef as above and also added a default value for the pref.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #491612 - Flags: review?(mnyromyr)

Comment 10

7 years ago
Comment on attachment 491612 [details] [diff] [review]
Tweaked patch

Seamonkey-Messenger-moa=me, given a Windows-based real review is passed (I don't have Windows).
Attachment #491612 - Flags: review?(mnyromyr) → review+
Comment on attachment 491612 [details] [diff] [review]
Tweaked patch

Patch works fine on Windows XP with a SeaMonkey trunk build
(Assignee)

Comment 12

7 years ago
Pushed changeset 740d1cf79d2b to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED

Updated

7 years ago
Blocks: 616825
Target Milestone: --- → Thunderbird 3.3a2

Updated

4 years ago
Depends on: 857647
You need to log in before you can comment on or make changes to this bug.