605982 - mozMatchesSelector should raise a SYNTAX_ERR exception on invalid selectors

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Matt Cosentino]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.11) Gecko/20101012 Firefox/3.6.11
Build Identifier: 

Currently mozMatchesSelector returns false when called with an invalid selector, this is the wrong behavior.  Here is what the W3C draft says:

"If the given group of selectors is invalid ([SELECT], section 13), the implementation must raise a SYNTAX_ERR exception ([DOM-LEVEL-3-CORE], section 1.4)."

The webkit and ie implementations of this method correctly raise the exception.

Reproducible: Always

Steps to Reproduce:
1. Call mozMatchesSelector with an invalid selector.
Actual Results:  
returns false

Expected Results:  
raises SYNTAX_ERR exception

Comment 1

[Jeff Walden [:Waldo]]

Compatibility concern, content/base/src/nsGenericElement.cpp looks easy to fix even for someone not really familiar with the code, should address for this release, I think.

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

I'm wondering if we shouldn't add the tests to content/base/test/file_bug416317.xhtml?

Comment 3

[Mounir Lamouri (:mounir)]

By the way, thank you for your report, Matt :)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 484864 [details] [diff] [review]
Patch v1

I'm fine either way on the test, but you should be propagating out the actual error from ParseSelectorList instead of assuming it's always SYNTAX_ERR.

Comment 5

[Mounir Lamouri (:mounir)]

Attachment: Patch v2

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 485006 [details] [diff] [review]
Patch v2

r=me

Comment 7

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/25507af6a959

Thank you for your report Matt :)

Comment 8

[Eric Shepherd [:sheppy]]

Updated documentation:

https://developer.mozilla.org/en/DOM/Node.mozMatchesSelector

Noted on Firefox 4 for developers.