606070 - warning C4244: 'return' : conversion from 'const PRUint64' to 'PLDHashNumber' in nsHashKeys.h

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

nsHashKeys.h(187) : warning C4244: 'return' : conversion from 'const PRUint64' to 'PLDHashNumber', possible loss of data

This gets spammed all over due to nsHashKeys.h being included in so many different files.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Bah.  Want to add an explicit cast and I'll review?

Comment 2

[Ryan VanderMeulen [:RyanVM]]

{ return NS_PTR_TO_INT32(aKey); } seems to work. Should I be doing that or NS_PTR_TO_UINT32?

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Patch v1

Anyway, here's my patch. Let me know if I need to change it to UINT32 instead.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 485207 [details] [diff] [review]
Patch v1

No, this is wrong.  You're returning the pointer to the key, not the key itself.  You just want to cast *aKey to PLDHashNumber.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Sorry for not answering comment 2; I never got that bugmail.  :(

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Attachment: Patch v2

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 485501 [details] [diff] [review]
Patch v2

r=me

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 485501 [details] [diff] [review]
Patch v2

Trivial warning fix.

Comment 9

[Jacek Caban]

http://hg.mozilla.org/mozilla-central/rev/3094ee9b5868