Closed
Bug 606087
Opened 14 years ago
Closed 14 years ago
don't recreate frames for inlines with overflow style applied
Categories
(Core :: CSS Parsing and Computation, defect, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla5
People
(Reporter: surkov, Assigned: bzbarsky)
References
Details
Attachments
(2 files, 1 obsolete file)
|
1.39 KB,
patch
|
dbaron
:
review+
|
Details | Diff | Splinter Review |
|
3.75 KB,
patch
|
MarcoZ
:
review+
|
Details | Diff | Splinter Review |
follow up from bug 570275 comment #44: > At least currently when page have style "a:focus { overflow: scroll; }" and > user navigates through links then nothing special happens visually That depends on whether links are styled with display:inline or not.... "overflow" simply doesn't apply to inlines. We could almost certainly change the style system to not reframe for overflow changes to inlines specifically, but there are likely other reframe changes which you don't want to treat as hide/show... the testcase would be <html> <head> <style> a:focus { overflow: scroll; } </style> </head> <body> <a href="www">anchor</a> </body> </html> when anchor is focused then its frame is recreated what is unwanted for accessibility and I think for layout as well.
|
Assignee | |
Updated•14 years ago
|
Component: Layout → Style System (CSS)
QA Contact: layout → style-system
|
|
Assignee | |
Comment 1•14 years ago
|
||
|
Reporter | |
Comment 2•14 years ago
|
||
(In reply to comment #1) > Created attachment 484952 [details] [diff] [review] > Don't reframe if overflow styles change on inlines. Boris if you need then I can fix a11y mochitests for this since they might fail.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #484952 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•14 years ago
|
Priority: -- → P3
Whiteboard: [need review]
|
|
Assignee | |
Comment 3•14 years ago
|
||
alexander, which try builds do I need to run to check whether the a11y tests pass?
|
|
Reporter | |
Comment 4•14 years ago
|
||
I think it should be -u mochitest-o, at least they appear for oth builds at http://tbpl.mozilla.org/
|
|
Reporter | |
Comment 5•14 years ago
|
||
btw, a11y tests should be ok after bug 570275 since tree/test_cssoverflow.html mochitests that should be affected was changed.
|
|
Reporter | |
Comment 6•14 years ago
|
||
(In reply to comment #5) > btw, a11y tests should be ok after bug 570275 since tree/test_cssoverflow.html > mochitests that should be affected was changed. I'm going to land it soon, perhaps it makes sense to wait for it.
Comment on attachment 484952 [details] [diff] [review] Don't reframe if overflow styles change on inlines. r=dbaron
Attachment #484952 -
Flags: review?(dbaron) → review+
|
|
Reporter | |
Comment 9•14 years ago
|
||
Attachment #484965 -
Attachment is obsolete: true
Attachment #484990 -
Flags: review?(marco.zehe)
|
||
Updated•14 years ago
|
Attachment #484990 -
Flags: review?(marco.zehe) → review+
|
|
Assignee | |
Comment 10•14 years ago
|
||
I'll hold off on landing this till after gecko 2, unless someone thinks we should do it before.
Assignee: nobody → bzbarsky
Whiteboard: [need review] → [need gk2 ship]
|
|
Assignee | |
Comment 11•14 years ago
|
||
Pushed http://hg.mozilla.org/projects/birch/rev/ddb589a7e13e
Flags: in-testsuite+
Whiteboard: [need gk2 ship] → fixed-in-birch
https://hg.mozilla.org/mozilla-central/rev/ddb589a7e13e
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-birch
Target Milestone: --- → mozilla2.2
You need to log in
before you can comment on or make changes to this bug.
Description
•