Closed Bug 606087 Opened 9 years ago Closed 9 years ago

don't recreate frames for inlines with overflow style applied

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla5

People

(Reporter: surkov, Assigned: bzbarsky)

References

Details

Attachments

(2 files, 1 obsolete file)

follow up from bug 570275 comment #44:

> At least currently when page have style "a:focus { overflow: scroll; }" and
> user navigates through links then nothing special happens visually

That depends on whether links are styled with display:inline or not.... 
"overflow" simply doesn't apply to inlines.  We could almost certainly change
the style system to not reframe for overflow changes to inlines specifically,
but there are likely other reframe changes which you don't want to treat as
hide/show...

the testcase would be

<html>
<head>
  <style>
    a:focus { overflow: scroll; }
  </style>
</head>
<body>
<a href="www">anchor</a>
</body>
</html>

when anchor is focused then its frame is recreated what is unwanted for accessibility and I think for layout as well.
Component: Layout → Style System (CSS)
QA Contact: layout → style-system
(In reply to comment #1)
> Created attachment 484952 [details] [diff] [review]
> Don't reframe if overflow styles change on inlines.

Boris if you need then I can fix a11y mochitests for this since they might fail.
Attachment #484952 - Flags: review?(dbaron)
Priority: -- → P3
Whiteboard: [need review]
alexander, which try builds do I need to run to check whether the a11y tests pass?
I think it should be -u mochitest-o, at least they appear for oth builds at http://tbpl.mozilla.org/
btw, a11y tests should be ok after bug 570275 since tree/test_cssoverflow.html mochitests that should be affected was changed.
(In reply to comment #5)
> btw, a11y tests should be ok after bug 570275 since tree/test_cssoverflow.html
> mochitests that should be affected was changed.

I'm going to land it soon, perhaps it makes sense to wait for it.
Comment on attachment 484952 [details] [diff] [review]
Don't reframe if overflow styles change on inlines.

r=dbaron
Attachment #484952 - Flags: review?(dbaron) → review+
Attached patch mochitest fix (obsolete) — Splinter Review
this should fix a11y mochitest
Attachment #484965 - Attachment is obsolete: true
Attachment #484990 - Flags: review?(marco.zehe)
Attachment #484990 - Flags: review?(marco.zehe) → review+
I'll hold off on landing this till after gecko 2, unless someone thinks we should do it before.
Assignee: nobody → bzbarsky
Whiteboard: [need review] → [need gk2 ship]
Pushed http://hg.mozilla.org/projects/birch/rev/ddb589a7e13e
Flags: in-testsuite+
Whiteboard: [need gk2 ship] → fixed-in-birch
https://hg.mozilla.org/mozilla-central/rev/ddb589a7e13e
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: fixed-in-birch
Target Milestone: --- → mozilla2.2
Depends on: 686247
You need to log in before you can comment on or make changes to this bug.