606279 - Remove the shmem-backed canvas and the shmem DocumentRenderers (but keep the serializing DocumentRenderer for now)

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

First step in the death march of shmem canvas.  This step doesn't depend on shadow-layer drawWindow or fast -moz-element.

The last consumer of shmem canvas is the fennec frontend, to create tab thumbnails.  These are sized to 104x65, which should result in a 13K 5-6-5 surface.  The frontend only takes these snapshots once per page load, after onload.  So we can serialize these bytes over the IPC pipe with no problems.

I'm hot to do this because non-shared canvas obsoletes bug 604282 and a related bug that's not yet filed.  Would like to eradicate those forevermore.

Comment 2

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: part 1: Excise shmem-backed canvas

Good patch, or greatest patch?

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: part 2: Use more concise types in PDocumentRenderer

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: part 3: Port transformed rendering to PDocumentRenderer

Comment 5

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Attachment: part 4: Only allocate an image large enough to cover the <canvas>

Comment 6

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I noticed that we're painting ARGB32 thumbnails, so we're actually sending 26KB instead of 13KB, but I'm not sure why we need alpha so I didn't poke.  (Also this seems fast enough on device.)  Please advise if it's worth looking into RGB16.

Comment 7

[Joe Drew (not getting mail)]

Comment on attachment 485363 [details] [diff] [review]
part 1: Excise shmem-backed canvas

I presume that DocumentRenderer is still used for tab previews?

Comment 8

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Correct, see comment 0.

Comment 9

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

I'd suggest blocking-b3 for this.  It fixes bug 604282 and bug 604282 comment 4, which isn't filed.

Comment 10

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 485363 [details] [diff] [review]
part 1: Excise shmem-backed canvas

\o/

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

Is this ready for beta 2?

Comment 12

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Yes.  I've been dogfooding it since last Thursday and haven't noticed a perf impact (and it can't regress talos, sadly).  Just need to check that it compiles on mac/windows.

Comment 13

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

All clear for when the tree reopens.

Comment 14

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

http://hg.mozilla.org/mozilla-central/rev/8eb26a77a90e
http://hg.mozilla.org/mozilla-central/rev/9f99e62fefb6
http://hg.mozilla.org/mozilla-central/rev/302c05f76344
http://hg.mozilla.org/mozilla-central/rev/ac44827872c9