606281 - IndexedDB: Don't return different objects representing the same object stores and indexes

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Patch attached.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch, v1

Comment 2

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 485092 [details] [diff] [review]
Patch, v1

>+      let objectStore1 = db.createObjectStore("foo", "");
>+      let objectStore2 = transaction.objectStore("foo");
>+      ok(objectStore1 === objectStore2, "Got same objectStores");
>+
>+      let index1 = objectStore1.createIndex("bar", "key");
>+      let index2 = objectStore2.index("bar");
>+      ok(index1 === index2, "Got same indexes");
>+
>+      transaction.oncomplete = continueToNextStep;
>+      yield;
>+
>+      transaction = db.transaction("foo");
>+
>+      objectStore1 = transaction.objectStore("foo");
>+      objectStore2 = transaction.objectStore("foo");
>+      ok(objectStore1 === objectStore2, "Got same objectStores");
>+
>+      index1 = objectStore1.index("bar");
>+      index2 = objectStore2.index("bar");
>+      ok(index1 === index2, "Got same indexes");

Please also test that the first set of objectStores/indexes are different from the second set of objectStores/indexes.

r=me with that.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

http://hg.mozilla.org/mozilla-central/rev/90d7637b9dc9