Closed
Bug 606331
Opened 14 years ago
Closed 14 years ago
Link timestamps to tweet permalink
Categories
(support.mozilla.org :: Army of Awesome, task)
support.mozilla.org
Army of Awesome
Tracking
(Not tracked)
VERIFIED
FIXED
2.2.7
People
(Reporter: williamr, Assigned: wenzel)
References
()
Details
Link tweet's timestamp so it will open a new tab/window to that tweet's permalink. Example permalink: http://twitter.com/#!/dailycavalier/status/26406528177 Link will change color to a blue when in a hover state.
Updated•14 years ago
|
Assignee: malexis → nobody
Target Milestone: --- → 2.2.7
Reporter | ||
Updated•14 years ago
|
Assignee: nobody → malexis
Comment 1•14 years ago
|
||
Fred, this is part of customer care v1.1 Target launch date is Nov 3
Assignee: malexis → fwenzel
Assignee | ||
Comment 2•14 years ago
|
||
More goodness: http://github.com/fwenzel/kitsune/commit/c319199 For extra credit, I keep clicks on links from bubbling up the DOM tree now, so our signin popup doesn't come up when you click a link. jsocol: r? please!
Status: NEW → ASSIGNED
Reporter | ||
Comment 3•14 years ago
|
||
Nice job with extra credit :) Not sure if this matters, but I noticed that the new twitter.com is now using a slightly different permalink structure (adds "#!/" before username). However the old permalinks redirect properly to the new structure. Old permalink: http://twitter.com/{{ tweet.user }}/status/{{ tweet.id }} New permalink: http://twitter.com/#!/{{ tweet.user }}/status/{{ tweet.id }} Should we be using the new permalink structure? Or is that still experimental?
Assignee | ||
Comment 4•14 years ago
|
||
After some branching, it's now here: http://github.com/fwenzel/kitsune/commit/da8f833 or here http://github.com/fwenzel/kitsune/commits/606331-tweet-permalinks
Assignee | ||
Comment 5•14 years ago
|
||
When I go to twitter without being logged in, I get "old-style" links, so I think we are fine using those.
Reporter | ||
Comment 6•14 years ago
|
||
Great, that sounds good to me.
Assignee | ||
Comment 7•14 years ago
|
||
Landed on 2.2.x and master.
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•