606331 - Link timestamps to tweet permalink

Status: VERIFIED FIXED

(support.mozilla.org :: Army of Awesome, task)

Description

[William Reynolds [:williamr]]

Link tweet's timestamp so it will open a new tab/window to that tweet's permalink.

Example permalink: http://twitter.com/#!/dailycavalier/status/26406528177

Link will change color to a blue when in a hover state.

Comment 1

[Mike Alexis [:malexis]]

Fred, this is part of customer care v1.1

Target launch date is Nov 3

Comment 2

[Fred Wenzel [:wenzel]]

More goodness:

http://github.com/fwenzel/kitsune/commit/c319199

For extra credit, I keep clicks on links from bubbling up the DOM tree now, so our signin popup doesn't come up when you click a link.

jsocol: r? please!

Comment 3

[William Reynolds [:williamr]]

Nice job with extra credit :)

Not sure if this matters, but I noticed that the new twitter.com is now using a slightly different permalink structure (adds "#!/" before username). However the old permalinks redirect properly to the new structure.

Old permalink: http://twitter.com/{{ tweet.user }}/status/{{ tweet.id }}
New permalink: http://twitter.com/#!/{{ tweet.user }}/status/{{ tweet.id }}

Should we be using the new permalink structure? Or is that still experimental?

Comment 4

[Fred Wenzel [:wenzel]]

After some branching, it's now here: http://github.com/fwenzel/kitsune/commit/da8f833 or here http://github.com/fwenzel/kitsune/commits/606331-tweet-permalinks

Comment 5

[Fred Wenzel [:wenzel]]

When I go to twitter without being logged in, I get "old-style" links, so I think we are fine using those.

Comment 6

[William Reynolds [:williamr]]

Great, that sounds good to me.

Comment 7

[Fred Wenzel [:wenzel]]

Landed on 2.2.x and master.

Comment 8

[Rebecca Billings [:rbillings]]

Verified timestamps link correctly to tweet