606342 - Load additional tweets when user scrolls to bottom of page

Status: VERIFIED FIXED

(support.mozilla.org :: Army of Awesome, task)

Description

[William Reynolds [:williamr]]

Add infinite scrolling functionality to the tweet list. Similar to twitter.com, trigger an AJAX request when a user is near the bottom of the page that appends additional tweets to end of list.

Tweets are retrieved from database and once all tweets are retrieved, no more requests are made and no message is displayed.

My understanding is that we only store the 500 most recent tweets in our database. Can someone verify? Maybe Fred? Want to make sure there's a limit on how many tweets we show.

There's a jQuery plugin that might be helpful for this:
http://www.infinite-scroll.com/infinite-scroll-jquery-plugin/

Comment 1

[Fred Wenzel [:wenzel]]

(In reply to comment #0)
> My understanding is that we only store the 500 most recent tweets in our
> database. Can someone verify? Maybe Fred? Want to make sure there's a limit on
> how many tweets we show.

Yes, that's the current limit.

Comment 2

[Fred Wenzel [:wenzel]]

I've got some code ready that should do precisely what you comment 0 asks for:
http://github.com/fwenzel/kitsune/compare/606342-scroll-tweets

I already pinged jsocol with an r? .

QA / William: When this lands on staging, please make sure the footer is still reasonably reachable. My worry is that once you scroll to the end, the infinite scrolling will push the footer out of the viewport again, causing you to scroll down further, which will once again trigger an extension of the tweet list (etc.). If that's an issue, perhaps we have to get a little more creative :)

Comment 3

[Fred Wenzel [:wenzel]]

Landed this on master:
http://github.com/jsocol/kitsune/commit/ce9fafc

... and merged into 2.2.x:
http://github.com/jsocol/kitsune/commit/f686ce0

Please file enhancement bugs if something needs tweaked, or reopen if anything major is broken.

Comment 4

[William Reynolds [:williamr]]

Reopening since this feature isn't working on stage right now due to bug 608317. Will close this again once that's fixed.

Comment 5

[Fred Wenzel [:wenzel]]

Wfm on stage, please test again.

Comment 6

[Rebecca Billings [:rbillings]]

I just checked out support-stage.mozilla.com and it scrolls to 140 tweets- is that the maximum set or is there another condition applied to what displays?

Comment 7

[Rebecca Billings [:rbillings]]

I just checked out support-stage.mozilla.com and it scrolls to 140 tweets- is that the maximum set or is there another condition applied to what displays?

Comment 8

[James Socol [:jsocol, :james]]

It only displays English tweets, which might be related (though 360/500 tweets in non-English seems high).

Comment 9

[William Reynolds [:williamr]]

I just tried twice and got 220 and 260 tweets after scrolling.

Can anyone reproduce showing a max of 140 tweets?

Comment 10

[Rebecca Billings [:rbillings]]

I just tried another browser and got 230- but whether it's 140/220/260 that's still far below the 500 limit.

Comment 11

[William Reynolds [:williamr]]

I'm okay with maxing out at ~200 tweets. Curious if we can reproduce the 140.

@Fred: of the 500 recent tweets we store in the database, do they all meet our filters? or have they not been filtered yet?

Comment 12

[Fred Wenzel [:wenzel]]

(In reply to comment #11)
> @Fred: of the 500 recent tweets we store in the database, do they all meet our
> filters? or have they not been filtered yet?

They meet all the filters except language. For displaying, Alex filtered out the non-English ones.

Comment 13

[Rebecca Billings [:rbillings]]

Marking this as verified. I'll keep an eye out to see if the shorter list repros, but I can't do it for the time being.