606366 - Port to SM Remove .wrappedJSObject gets that don't work with the new wrappers

Status: RESOLVED FIXED

(SeaMonkey :: Session Restore, defect)

Description

[Ian Neal]

http://hg.mozilla.org/mozilla-central/rev/574b0fb35604 fixed issues on m-c for certain tests that didn't work with the new wrappers, we should do the same for browser_393716.js and browser_bug510890.js

Comment 1

[Ian Neal]

Attachment: Patch to remove broken wrapper v0.1 [Checked in: Comment 2]

Patch that ports the fix.

Comment 2

[Ian Neal]

Comment on attachment 485186 [details] [diff] [review]
Patch to remove broken wrapper v0.1 [Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/04465db8a913

Comment 3

[Ian Neal]

Attachment: Let's fix the session core code too [Checked in: Comment 9]

This patch fixes up the session core code too.

Comment 4

[Ian Neal]

(In reply to comment #3)
> Created attachment 485500 [details] [diff] [review]
> Let's fix the session core code too
> 
> This patch fixes up the session core code too.

Ported from m-c changeset http://hg.mozilla.org/mozilla-central/rev/956791edd7be

Comment 5

[Ian Neal]

(In reply to comment #4)
> (In reply to comment #3)
> > Created attachment 485500 [details] [diff] [review] [details]
> > Let's fix the session core code too
> > 
> > This patch fixes up the session core code too.
> 
> Ported from m-c changeset
> http://hg.mozilla.org/mozilla-central/rev/956791edd7be

For some reason this fixes the two broken tests but breaks browser_339445.js test :(

Comment 6

[[e-mail]]

Comment on attachment 485500 [details] [diff] [review]
Let's fix the session core code too [Checked in: Comment 9]

This one turned out to be easier to reproduce than I expected, since session store based undo close tab of about:config is completely broken without this.

Comment 7

[[e-mail]]

(In reply to comment #5)
> For some reason this fixes the two broken tests but breaks browser_339445.js
> test :(
Sorry I didn't see this. (But I have no idea why it might affect that test.)

Comment 8

[[e-mail]]

(In reply to comment #5)
> For some reason this fixes the two broken tests but breaks browser_339445.js
> test :(
That test passes locally for me with or without the patch.

Comment 9

[Ian Neal]

Comment on attachment 485500 [details] [diff] [review]
Let's fix the session core code too [Checked in: Comment 9]

http://hg.mozilla.org/comm-central/rev/13f39f4c3636

Comment 10

[Serge Gautherie (:sgautherie)]

This bug should be fixed now, unless any of the following occurrences needs fixing too:
http://mxr.mozilla.org/comm-central/search?string=.wrappedJSObject&case=1&find=%2Fsuite%2F.*%5C.js%24
"Found 10 matching lines in 9 files"