Closed Bug 606491 Opened 14 years ago Closed 14 years ago

Submit controls should be barred from constraint validation

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b10
Tracking Flags:
Tracking Status
blocking2.0 --- .x+
status2.0 --- wanted

People

(Reporter: mounir, Assigned: mounir)

References

Details

(Keywords: dev-doc-complete, html5, Whiteboard: [good first bug][ptf])

Attachments

(2 files, 3 obsolete files)

Patch v1.2
33.58 KB, patch
smaug
: review+
mounir
: feedback+
jst
: approval2.0+
Details | Diff | Splinter Review
Part 2 - Updating tests
41.64 KB, patch
smaug
: review+
jst
: approval2.0+
Details | Diff | Splinter Review 
Submit elements are not barred from constraint validation for unknown reasons. Probably to let the authors use .setCustomValidity() on them thus making them invalid and style them accordingly.
We should recommend :-moz-submit-invalid for the moment and make submit elements barred from constraint validation as soon as we have feedback on that on the spec side.

W3C bug:
http://www.w3.org/Bugs/Public/show_bug.cgi?id=10910
Summary: Submit elements should be barred from constraint validation → Submit controls should be barred from constraint validation
Attached patch Patch v1 (obsolete) — — Splinter Review 

  

  


Assignee: nobody → linux.anas
Status: NEW → ASSIGNED

        Attachment #490364 -
        Flags: review?(Olli.Pettay)

        Attachment #490364 -
        Flags: feedback?(mounir.lamouri)

    
  
Whiteboard: [good first bug] → [good first bug][ptf]

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v1.1 (obsolete)
        — 
          — Splinter Review
      

    


  
I've updated this patch to tip.

It looks like some tests are failing in content/html/content/tests:
content/html/content/test/test_bug345512.html
content/html/content/test/test_bug345624-1.html
content/html/content/test/test_bug345822.html
content/html/content/test/test_bug557087-3.html
content/html/content/test/test_bug600155.html

These are mochitests, you can learn more about them here https://developer.mozilla.org/en/Mochitest (especially how to run them if you don't).

  

  



        Attachment #490364 -
        Attachment is obsolete: true

        Attachment #490388 -
        Flags: review?(Olli.Pettay)

        Attachment #490388 -
        Flags: feedback+

        Attachment #490364 -
        Flags: review?(Olli.Pettay)

        Attachment #490364 -
        Flags: feedback?(mounir.lamouri)

    
    

    
  
f=me with the tests fixed, btw

  

  



    
    

    
  
Comment on attachment 490388 [details] [diff] [review]
Patch v1.1

I'll review once Mounir's comment is addressed.

  

  



        Attachment #490388 -
        Flags: review?(Olli.Pettay)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Patch v1.2
        — 
          — Splinter Review
      

    


  
I've updated Anas' patch to tip and I'm going to attach a patch fixing broken tests.

  

  



        Attachment #490388 -
        Attachment is obsolete: true

        Attachment #500206 -
        Flags: review?(Olli.Pettay)

        Attachment #500206 -
        Flags: feedback+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Part 2 - Updating tests (obsolete)
        — 
          — Splinter Review
      

    


  

  

  



        Attachment #500207 -
        Flags: review?(Olli.Pettay)

    
    

    
  
Re-assigning the bug to myself given that I want this to be fixed for Firefox 4.

  

  


Assignee: linux.anas → mounir.lamouri
Whiteboard: [good first bug][ptf] → [good first bug][ptf][needs-review]

    
    

    
  


  
Updating some other tests. Thanks to the try server :)

  

  



        Attachment #500207 -
        Attachment is obsolete: true

        Attachment #500264 -
        Flags: review?(Olli.Pettay)

        Attachment #500207 -
        Flags: review?(Olli.Pettay)

    
  
Whiteboard: [good first bug][ptf][needs-review] → [good first bug][ptf][needs-review][passed-try]

        Attachment #500264 -
        Flags: review?(Olli.Pettay) → review+

        Attachment #500206 -
        Flags: review?(Olli.Pettay) → review+

    
  

        Attachment #500206 -
        Flags: approval2.0?

    
  

        Attachment #500264 -
        Flags: approval2.0?

    
    

    
  
Approval request: this patch is not risky (only changing a few lines of code even if it requires to update a significant part of our tests suite) and would prevent us to support something that doesn't seem sane (being able to make a button invalid).

  

  


Whiteboard: [good first bug][ptf][needs-review][passed-try] → [good first bug][ptf][needs-approval][passed-try]

        Attachment #500206 -
        Flags: approval2.0? → approval2.0+

        Attachment #500264 -
        Flags: approval2.0? → approval2.0+

    
  
Whiteboard: [good first bug][ptf][needs-approval][passed-try] → [good first bug][ptf][passed-try][needs landing]

    
    

    
  
Pushed:
http://hg.mozilla.org/mozilla-central/rev/ab793a47ac07
http://hg.mozilla.org/mozilla-central/rev/814b67490af5

  

  


Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [good first bug][ptf][passed-try][needs landing] → [good first bug][ptf]
Target Milestone: --- → mozilla2.0b10

    
    

    
  
Updated documentation:

https://developer.mozilla.org/en/DOM/HTMLButtonElement
https://developer.mozilla.org/en/HTML/HTML5/Forms_in_HTML5#Constraint_Validation

Let me know if my understanding of this change is inaccurate.

  

  


Keywords: dev-doc-needed → dev-doc-complete

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: