606507 - Update addons module to support the Discovery Pane

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Aaron Train [:aaronmt]]

With the AddonsAPI updated in bug 569813, some additional functionality will be needed to support the Discovery Pane (i.e, "Get Add-ons") in tests.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It's not something we can do right now. It will take a while until the discovery pane has been finished. Also not sure yet how much we can and should do. It's a web page and will be different for each user. I would more tend to say, lets handle it as any other web page.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Before we start with the implementation of the tests we should figure out if we really need an API for the discovery pane.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

As bug 659000 has been shown we have issues with waitForPageLoad() in the discovery pane. We should have at least basic support for it in the addons module:

* waitForPageLoaded()
* .controller

Still not sure if an element list is useful here.

Comment 5

[u415141]

A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/13767591

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+1]]

I asked Vlad to send me a list of possible candidates for the elements the DiscoveryPane class has to cover. Here those are:

Name	Selector

Main
----
"main_featureNext"	#nav-features.next
"main_featurePrevious"	#nav-features.prev
"main_featureCollection"	#fx4-collection
"main_featureMonthly"	#monthly.install-button
"featured _addonsList"	#featured-addons
"recs_addonsList"	#recs
"sub_upAndComingList"	#up-and-coming
"sub_featuredPersonas"	#featured-personas
"sub_moreWays"	#more-ways

Details
-------
"detailedView_addToFirefox"	#install.install-button
"detailedView_LearnMore"	#learn-more

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Implementing handling of elements is not that easy here. If JS is enabled this pane is doing crazy things by at least cloning panels. I need some sleep first before I can continue here. Btw. the initial class already works.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: WIP v1 (basics + up-and-coming

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: WIP v1.1

WIP with example test with what's implemented so far.

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: WIP v1.2

Updated WIP which now includes the addon page too.

Vlad with this patch injected into your mq you can start to create tests for the up and coming Litmus tests.

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Final patch to handle the discovery pane with a couple of extra tests attached. Please keep in mind to run this on mozilla-beta if you want to test. With the fresh Aurora build we do not populate all sections because of missing compatible extensions.

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 535784 [details] [diff] [review]
Patch v1

diff --git a/lib/addons.js b/lib/addons.js
--- a/lib/addons.js
+++ b/lib/addons.js
   /**
+   * Get the instance of the Discovery Pane
+   *
+   * @returns {DiscoverPane} Instance of the Discovery Pane class
+   */

nit: typo in DiscoveryPane

new file mode 100644
--- /dev/null
+++ b/lib/tests/testAddonsDiscoveryPane.js
@@ -0,0 +1,107 @@
+// Include required modules
+var addons = require("../addons");

nit: Aren't we capitalising these now?

r+ with the above minor nits.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v2

Patch with comments addressed. Ready for check-in.

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/9be75c1668ac (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/32208596d82e (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/2853bea9812c (beta)

I have added more than the requested elements, and I think we should be feature complete for this class now. If something is missing file a new bug or add it on your own in a patch for a test.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We released a new beta to pyPI yesterday with the waitForPageLoad bug fixed. So we are good to go now. Removing dependency.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Sorry, had to push a follow-up bustage fix for the example test.

http://hg.mozilla.org/qa/mozmill-tests/rev/592ae2d20b33 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/e05099301075 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/bda592b5732d (beta)