Closed Bug 60659 Opened 24 years ago Closed 23 years ago

javascript strict warnings in pref-fonts.js

Categories

(SeaMonkey :: Preferences, defect, P3)

Product:
SeaMonkey
Component:
Preferences
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Future

People

(Reporter: bugzilla, Assigned: samir_bugzilla)

Details

Attachments

(6 files, 1 obsolete file)

patch
1.90 KB, patch
Details | Diff | Splinter Review
diff -u
4.03 KB, patch
Details | Diff | Splinter Review
diff that should work
5.62 KB, patch
Details | Diff | Splinter Review
lets try this again
6.15 KB, patch
Details | Diff | Splinter Review
updated patch
6.75 KB, patch
caillon
: review+
shaver
: superreview+
Details | Diff | Splinter Review
Fixed double-spacing
778 bytes, patch
caillon
: review+
shaver
: superreview+
Details | Diff | Splinter Review
JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 80: redeclaration of var prefvalue JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 89: redeclaration of var prefvalue JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 7: assignment to undeclared variable fonts JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 50: reference to undefined property aDataObject.languageData JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 51: reference to undefined property aDataObject.currentLanguage JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 57: reference to undefined property aDataObject.dataEls JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 57: reference to undefined property aDataObject.dataEls JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 76: reference to undefined property aDataObject.fontDPI JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 85: reference to undefined property aDataObject.useDocFonts JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 139: assignment to undecla red variable faces JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 156: assignment to undecla red variable gNoFontsForThisLang JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 273: reference to undefine d property languageData[languageList.data] JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 273: reference to undefine d property languageData[languageList.data] JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 273: reference to undefine d property languageData[languageList.data] JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 30: reference to undefined property dataObject.dataEls JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 240: reference to undefine d property languageData[currentLanguage] JavaScript strict warning: chrome://communicator/content/pref/pref-fonts.js line 242: reference to undefine d property languageData[currentLanguage].types
I don't see any strict warnings anymore (with javascript.options.strict on), the errors seems to have been fixed ( I checked every one of them)
Status: NEW → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Hmmm... I dont know you you concluded this one was fixed but: Warning: redeclaration of var prefvalue Source File: chrome://communicator/content/pref/pref-fonts.js Line: 92, Column: 20 Warning: redeclaration of var defaultListSelection Source File: chrome://communicator/content/pref/pref-fonts.js Line: 344, Column: 12 Warning: redeclaration of var selectedItem Source File: chrome://communicator/content/pref/pref-fonts.js Line: 374, Column: 20 Warning: reference to undefined property aDataObject.languageData Source File: chrome://communicator/content/pref/pref-fonts.js Line: 72 Warning: reference to undefined property aDataObject.dataEls Source File: chrome://communicator/content/pref/pref-fonts.js Line: 81 Warning: reference to undefined property aDataObject.fontDPI Source File: chrome://communicator/content/pref/pref-fonts.js Line: 102 Warning: reference to undefined property aDataObject.useDocFonts Source File: chrome://communicator/content/pref/pref-fonts.js Line: 135 Warning: reference to undefined property languageData[languageList.value] Source File: chrome://communicator/content/pref/pref-fonts.js Line: 346
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Sorry about that, for some reason moz didn't pickup my user.js. Since I'm here, I'll try to create a patch to get rid of the warnings, though this is a small problem compared to the many other warnings I'm getting from other js files.
Attached patch patch — — Splinter Review
please make the diff output: diff -u
Attached patch diff -u — — Splinter Review
Still getting (now also js error...): Warning: redeclaration of var prefvalue Source File: chrome://communicator/content/pref/pref-fonts.js Line: 92, Column: 20 Warning: redeclaration of var defaultListSelection Source File: chrome://communicator/content/pref/pref-fonts.js Line: 344, Column: 12 Warning: redeclaration of var selectedItem Source File: chrome://communicator/content/pref/pref-fonts.js Line: 374, Column: 20 Warning: reference to undefined property aDataObject.useDocFonts Source File: chrome://communicator/content/pref/pref-fonts.js Line: 135 Warning: reference to undefined property languageData[currentLanguage] Source File: chrome://communicator/content/pref/pref-fonts.js Line: 309 Error: invalid 'in' operand currentLanguage Source File: chrome://communicator/content/pref/pref-fonts.js Line: 309
Much better, but: Warning: assignment to undeclared variable calscreen Source File: chrome://communicator/content/pref/pref-fonts.js Line: 433
Taking to checkin for basic.
Assignee: matt → sgehani
Status: REOPENED → NEW
Keywords: patch, review
Target Milestone: --- → mozilla0.9.5
basic, Can you drive the review process? I'll check it in for you once this is r'd and sr'd. Thanks.
Target Milestone: mozilla0.9.5 → mozilla0.9.6
I can check this in once it is reviewed.
Target Milestone: mozilla0.9.6 → Future
This bug has not been touched in over three months; by now, basic's patch has probably bit-rotted. Anyone care to make progress on this thing?
I'll fix the warnings with my patch for bug 110342 (not yet attached there)
I decided to *not* fix it as part of 110342.
No longer depends on: 110342
Attached patch updated patch — — Splinter Review
With the attached patch, the only warning I'm seeing is: Warning: reference to undefined property screenResolution.getElementsByAttribute("value", resolution)[0] Source File: chrome://communicator/content/pref/pref-fonts.js Line: 517
Comment on attachment 75783 [details] [diff] [review] updated patch r=caillon for the changes, though it would be nice to also get that last warning fixed...
Attachment #75783 - Flags: review+
Comment on attachment 75783 [details] [diff] [review] updated patch sr=shaver, though the (existing) stylistic inconsistencies grate.
Attachment #75783 - Flags: superreview+
Attached patch Patch for the last case (obsolete) — — Splinter Review
Comment on attachment 80248 [details] [diff] [review] Patch for the last case r=caillon
Attachment #80248 - Flags: review+
Attachment #80248 - Attachment is obsolete: true
Comment on attachment 80285 [details] [diff] [review] Fixed double-spacing sr=shaver.
Attachment #80285 - Flags: superreview+
aren't these patches already checked in so that this can be marked fixed?
marking fixed. caillon checked in the patch for me.
Status: NEW → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
vrfy'd fixed using 2002.06.17.08 comm trunk bits (linux rh7.2).
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: