606611 - FF Home: Launching chooser option in native browser after page failed to load results in crash

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Firefox Home, defect)

Description

[Tony Chung [:tchung]]

I used the fake url example in bug 605161 to launch the chooser option in the native Home app.  This is after syncing it from desktop, and attempting to open the site.   As a result, the app will crash

Repro:
1) install FF Home 1.0.4b3
2) sync an URL from desktop sync that contains port, query, and fragment in the url (eg. see URL)
3) open FF HOme, and retrieve that url you sync'd through the native browser (i saved it to bookmarks)
4) Wait until URL is loaded (it will fail to load since its fake), and then notice the chooser icon appears in the bottom right hand corner
5) Verify clicking the chooser will crash FF Home

Expected:
- clicking the chooser should give the options to email, copy, or open in Safari

Actual:
- FF Home CRAshes

Comment 1

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

This is not related to specific parts of the URL. It seems we crash when you select the 'Share' button when a page failed to load. If this one is easy to fix I will try to sneak it into 1.0.4.

Comment 2

[Tony Chung [:tchung]]

ah, thanks for the investigation.   In that case im still voting this to block 1.0.4.  a person may hit a perfectly valid site that fails to load that moment, and blame the thought that on our native browser is broken.  so after the error message, they may think "i'll just open it in safari instead," and click chooser.   

And they'll hit the crash.

Comment 3

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Fixed. Will appear in 1.0.4b4

Changeset http://hg.mozilla.org/services/fx-home/rev/be6df1edbd76

Comment 4

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified:
iPhone 3 GS with iOS 4
iPod Touch with iOS 3.

Used Personal copy of FileMaker Pro 11 Advanced + IWP to verify as well as fake url address.