The default bug view has changed. See this FAQ.

Remove the DoInstantiateEmbeddedPlugin goop added in bug 484992

RESOLVED FIXED in mozilla7

Status

()

Core
Plug-ins
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: bz, Assigned: Josh Aas)

Tracking

Trunk
mozilla7
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

See bug 484992 comment 21.  I think nowadays since we have no default plugin we should be able to just use SetUpPluginInstance directly.
(Assignee)

Updated

7 years ago
Assignee: nobody → joshmoz
(Assignee)

Comment 1

6 years ago
Created attachment 528836 [details] [diff] [review]
fix v1.0
Attachment #528836 - Flags: review?(bzbarsky)
This isn't quite what I was thinking when I filed this bug...  I was thinking we could rip out this boolean argument altogether.
(Assignee)

Comment 3

6 years ago
Ah, I forgot about that. You mind if we take this cleanup first and I'll do that next?
Comment on attachment 528836 [details] [diff] [review]
fix v1.0

Sure.
Attachment #528836 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 5

6 years ago
pushed fix v1.0 to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/e9dafe775b31
(Assignee)

Updated

6 years ago
Attachment #528836 - Attachment description: fix v1.0 → cleanup v1.0
(Assignee)

Comment 6

6 years ago
Created attachment 534483 [details] [diff] [review]
fix v2.0
(Assignee)

Updated

6 years ago
Attachment #528836 - Attachment description: cleanup v1.0 → fix v1.0
(Assignee)

Updated

6 years ago
Attachment #534483 - Attachment description: fix v1.0 → fix v2.0
(Assignee)

Comment 7

6 years ago
I'm not sure that fix v2.0 is really something we want yet, but I want to make sure that it addresses bz's concern, or is at least on the right track.
(Assignee)

Updated

6 years ago
Attachment #534483 - Flags: review?(jst)
Comment on attachment 534483 [details] [diff] [review]
fix v2.0

Since you want to know whether this addresses bz's concerns I think he should review here :)

Looks good to me fwiw, but I didn't dig too deep here.
Attachment #534483 - Flags: review?(jst) → review?(bzbarsky)
I already told Josh that this addresses my concerns.  Now it needs correctness review, and I have no clue whether this is correct....  So I can't really review it.
Comment on attachment 534483 [details] [diff] [review]
fix v2.0

Ok, this looks correct to me. r=jst
Attachment #534483 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 11

6 years ago
pushed to mozilla-central

http://hg.mozilla.org/mozilla-central/rev/7a6804f6034e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Could anyone provide some clear Steps to reproduce in order to have this issue verified? Thanks.
You need to log in before you can comment on or make changes to this bug.