See bug 484992 comment 21. I think nowadays since we have no default plugin we should be able to just use SetUpPluginInstance directly.
Created attachment 528836 [details] [diff] [review] fix v1.0
This isn't quite what I was thinking when I filed this bug... I was thinking we could rip out this boolean argument altogether.
Ah, I forgot about that. You mind if we take this cleanup first and I'll do that next?
Comment on attachment 528836 [details] [diff] [review] fix v1.0 Sure.
pushed fix v1.0 to mozilla-central http://hg.mozilla.org/mozilla-central/rev/e9dafe775b31
I'm not sure that fix v2.0 is really something we want yet, but I want to make sure that it addresses bz's concern, or is at least on the right track.
Comment on attachment 534483 [details] [diff] [review] fix v2.0 Since you want to know whether this addresses bz's concerns I think he should review here :) Looks good to me fwiw, but I didn't dig too deep here.
I already told Josh that this addresses my concerns. Now it needs correctness review, and I have no clue whether this is correct.... So I can't really review it.
Comment on attachment 534483 [details] [diff] [review] fix v2.0 Ok, this looks correct to me. r=jst
pushed to mozilla-central http://hg.mozilla.org/mozilla-central/rev/7a6804f6034e
Could anyone provide some clear Steps to reproduce in order to have this issue verified? Thanks.