Invalid form popup shouldn't create a text node but use a <description/>

RESOLVED FIXED in Firefox 4.0b7

Status

()

defect
--
minor
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: mounir, Assigned: mounir)

Tracking

Trunk
Firefox 4.0b7
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

9 years ago
Posted patch Patch v1Splinter Review
No description provided.
Attachment #485488 - Flags: review?(gavin.sharp)
Attachment #485488 - Flags: approval2.0?
Comment on attachment 485488 [details] [diff] [review]
Patch v1

>diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js

>     // Limit the message to 256 characters.
>-    this.panel.firstChild.nodeValue = element.validationMessage.substring(0, 256);
>+    this.panel.firstChild.textContent = element.validationMessage.substring(0, 256);

Not related to this bug, but this limit needs to be mentioned in an L10N note in dom.properties, otherwise localizers risk overflowing it...
https://developer.mozilla.org/en/Localization_notes
Attachment #485488 - Flags: review?(gavin.sharp)
Attachment #485488 - Flags: review+
Attachment #485488 - Flags: approval2.0?
Attachment #485488 - Flags: approval2.0+
Assignee

Comment 2

9 years ago
Pushed:
http://hg.mozilla.org/mozilla-central/rev/476e365b2fc5

I've open bug 606817 for the l10n note.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
Target Milestone: Firefox 4.0b8 → Firefox 4.0b7
You need to log in before you can comment on or make changes to this bug.