60680 - Reflows cause default plugin to appear/reappear

Status: RESOLVED WORKSFORME

(Core Graveyard :: Plug-ins, defect, P3)

Description

[Cesar Eduardo Barros]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.17 i686; en-US; m18) Gecko/20001117
BuildID:    2000111708

When loading the page (with no plugins installed), the Default Plugin pops up.
If I click "Cancel" and wait a bit, it appears again. And again. And again. It
stops only if I manage to quickly close the window after clicking Cancel but
before it appears again.

Reproducible: Always
Steps to Reproduce:
Open the page and wait for it to load

Actual Results:  An infinite amount of Default Plugin dialogs

Expected Results:  Only one Default Plugin dialog per content type per page

My build is a .sea one from mozillazine, in case it makes any difference.

Comment 1

[shrirang khanzode]

dup

*** This bug has been marked as a duplicate of 59936 ***

Comment 2

[Cesar Eduardo Barros]

No, this is *not* a dupe of 59936.

Bug 59936 is about the dialog not closing when you click OK; this bug is about
the dialog reappearing after clicking Cancel, an *infinite* (well, at least 30+)
number of times. In bug 59936, clicking 'Cancel' is enough to make things fine;
in this one, you have to close the *window* which is generating the dialogs to
make them go away (since Cancel only opens a new one).

I'm trying to reopen (don't know if I can)

Comment 3

[shrirang khanzode]

how about bug 57455..

Comment 4

[Cesar Eduardo Barros]

Probably not. That one is about reloads triggered by resizes trying to reload
the plugin; this one is about something on that page that is continuously
respawning the plugin.

The only thing similar in both is the workaround: make a default plugin dialog
appear only once per full reload per contenty type per page. The true solution
for 57455 would be for the default plugin to check for reloads caused by
resizing and not show itself in that case; the true solution here would be to
find what is causing the infinite plugin reload loop (I can see only one applet
there, and no reason for it to reload at all).

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I suspect it is a dup of bug 57455 -- I think we have situations where animated
GIFs trigger additional reflows (see bug 60880), which trigger the plugin dialog.

Comment 6

[shrirang khanzode]

I noticed something. Every damn link from this page goes to a page with some 
applets embedded. So, of course, with each occurance of a page with missing 
plugin, the defaul plugin will pop up asking the user to download the plugin. I 
do not see the default plugin dialog pop up more than once if I go to the url 
above and *just stay there*. Marking this bug INVALID. 

Comment 7

[Cesar Eduardo Barros]

"INVALID"?

INVALID should be for things that are not bugs, right?

Well, this was a bug. The dialog appeared infinite times if you just sit there.
Hardly INVALID.

And yes, it does not appear anymore as of 2000121112. The right answer is
WORKSFORME.

I'll try to change it.

Comment 8

[Cesar Eduardo Barros]

Marking WORKSFORME.