Closed Bug 606976 Opened 15 years ago Closed 15 years ago

SharedDIBWin doesn't need to map its shared memory

Categories

(Core Graveyard :: Plug-ins, defect)

Product:
Core Graveyard
Component:
Plug-ins
Platform:
x86
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: benjamin, Unassigned)

Details

Currently SharedDIB is only used by SharedDIBWin, and that class doesn't actually use the mapped memory segment directly: it only uses it through ::CreateDIBSection. This means that we end up mapping the memory segment twice: once explicitly at http://mxr.mozilla.org/mozilla-central/source/gfx/ipc/SharedDIB.cpp#64 and once implicitly in ::CreateDIBSection. I think we can just remove the Map() call entirely in SharedDIB. jmathies, can you think of any particular reason we need to map that memory?
I don't see why not assuming CreateDIBSection maps the file into a section. Have you tried it, and does CreateDIBSection succeed?
http://hg.mozilla.org/mozilla-central/rev/da433c7320ab
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.