607008 - Newsletter form JS broken on 3.6 firstrun page

Status: VERIFIED FIXED

Description

[Steven Garrity [:sgarrity]]

It appears that r75077 broke the JS on the product 3.6 firstrun page (when it got pushed to production in r76046).

The newsletter-form.js file is no longer being included. Fortunately, the page was coded such that it fails gracefully without JS and links to the newsletter signup page instead of the in-line form.

Comment 1

[Michael Morgan [:morgamic]]

Hey Anthony, I think this is probably already taken care of in your latest patches.  Can you make sure this is fixed on trunk?

Comment 2

[Anthony Ricaud (:rik)]

Yes, this is fixed on trunk. Please review and push to production my patch in bug 589315. This will degrade performance (which was the primary goal) but I'll make improvements later.

Comment 3

[Anthony Ricaud (:rik)]

Oh, I read this too fast. r75077 is not in prod yet, just a part of it. So r75077 can be completely pushed in production along with my patch.

Comment 4

[raymond [:retornam] (inactive)]

qa-verified-trunk http://www-trunk.stage.mozilla.com/en-US/firefox/3.6/firstrun/

Comment 5

[Alex Buchanan [:abuchanan]]

This was fixed inadvertently through another bug.

Comment 6

[raymond [:retornam] (inactive)]

verified fixed http://www.mozilla.com/en-US/firefox/3.6/firstrun/