Closed Bug 607008 Opened 15 years ago Closed 15 years ago

Newsletter form JS broken on 3.6 firstrun page

Categories

(www.mozilla.org :: General, defect)

Product:
www.mozilla.org
Component:
General
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: sgarrity, Assigned: rik)

References

(
URL
)

Details

It appears that r75077 broke the JS on the product 3.6 firstrun page (when it got pushed to production in r76046). The newsletter-form.js file is no longer being included. Fortunately, the page was coded such that it fails gracefully without JS and links to the newsletter signup page instead of the in-line form.
Hey Anthony, I think this is probably already taken care of in your latest patches. Can you make sure this is fixed on trunk?
Assignee: morgamic → anthony
Yes, this is fixed on trunk. Please review and push to production my patch in bug 589315. This will degrade performance (which was the primary goal) but I'll make improvements later.
Oh, I read this too fast. r75077 is not in prod yet, just a part of it. So r75077 can be completely pushed in production along with my patch.
Keywords: qawanted
This was fixed inadvertently through another bug.
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: push-needed
Resolution: --- → FIXED
verified fixed http://www.mozilla.com/en-US/firefox/3.6/firstrun/
Status: RESOLVED → VERIFIED
Component: www.mozilla.org/firefox → www.mozilla.org
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.