607042 - Warning: preg_match() [function.preg-match]: Unknown modifier 'c' in /data/www

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

http://nova.stage.mozilla.com/en-US/firefox/all.html?lang-search=%3C%2Fscript%3E%3Cscript%3Ealert%28%22XSS!%22%29%3B%3C%2Fscript%3E&x=22&y=14 yields a bunch of this warning:

Warning: preg_match() [function.preg-match]: Unknown modifier 'c' in /data/www/nova.stage.mozilla.com/includes/product-details/firefoxDetails.class.php on line 485

Comment 1

[Michael Gauthier [:gauthierm]]

Attachment: patch to quote dynamic regular expression

Looks like there was just a typo in the original code. It was supposed to be quoted.

Comment 2

[Alex Buchanan [:abuchanan]]

Comment on attachment 485827 [details] [diff] [review]
patch to quote dynamic regular expression

Code change looks fine, but I don't think this fixes the problem.  When I tested locally, I still get the error.

Comment 3

[Michael Gauthier [:gauthierm]]

The delimiter needs to be specified for preg_quote(). Add a second parameter to preg_quote() to fix:

$_keywords = preg_quote($keywords, '/');

Comment 4

[Alex Buchanan [:abuchanan]]

Can I have a patch please?

Comment 5

[Michael Gauthier [:gauthierm]]

Attachment: second version of patch with one line change

second version of patch with one line change, see bug history for details

Comment 6

[Alex Buchanan [:abuchanan]]

r76715 on trunk.

Comment 7

[Alex Buchanan [:abuchanan]]

Comment on attachment 487342 [details] [diff] [review]
second version of patch with one line change

Thank you.

Comment 8

[Alex Buchanan [:abuchanan]]

This will be pushed to production with the next update of p-d (usually a product release).  I think it can wait until then.

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

qa-verified-trunk

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED -- pushed to prod, don't see any errors (thought I didn't before, I still don't, obviously).