VendorID and AdapterID are 0000

RESOLVED FIXED

Status

()

Core
Graphics
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

7 years ago
About 4.4% of crashes don't have proper device ids. We should see what we can do about this.
(Assignee)

Comment 1

7 years ago
We can probably track this down by (ab)using the device_id to return a more specific error code.
(Assignee)

Comment 2

7 years ago
Created attachment 486210 [details] [diff] [review]
Try to give some more visibility into what's going wrong here

This patch adds additional information to the crashdumps when we fail to get a proper vendor_id/device_id
Attachment #486210 - Flags: review?(ehsan)
(Assignee)

Updated

7 years ago
Attachment #486210 - Flags: review?(ehsan)
You may want to append GetLastError() to the debug string as well, in case a call fails along the way.
(Assignee)

Comment 4

7 years ago
Created attachment 486987 [details] [diff] [review]
v2
Attachment #486210 - Attachment is obsolete: true
Attachment #486987 - Flags: review?(gavin.sharp)
Comment on attachment 486987 [details] [diff] [review]
v2

r=me with the moving of NullSearch as we discussed IRL.

maybe print mDeviceKeyDebug first for readability, since mDeviceID might be crazy?
Attachment #486987 - Flags: review?(gavin.sharp) → review+
Assignee: nobody → jmuizelaar
Sigh, sorry Jeff, qimport didn't preserve blame it seems, but here's your change:
http://hg.mozilla.org/mozilla-central/rev/3ee96c3879bc

Comment 8

7 years ago
I supposed it is fixed.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.