About 4.4% of crashes don't have proper device ids. We should see what we can do about this.
We can probably track this down by (ab)using the device_id to return a more specific error code.
Created attachment 486210 [details] [diff] [review] Try to give some more visibility into what's going wrong here This patch adds additional information to the crashdumps when we fail to get a proper vendor_id/device_id
You may want to append GetLastError() to the debug string as well, in case a call fails along the way.
Created attachment 486987 [details] [diff] [review] v2
Comment on attachment 486987 [details] [diff] [review] v2 r=me with the moving of NullSearch as we discussed IRL. maybe print mDeviceKeyDebug first for readability, since mDeviceID might be crazy?
Attachment #486987 - Flags: review?(gavin.sharp) → review+
Attachment #486987 - Flags: approval2.0+
Sigh, sorry Jeff, qimport didn't preserve blame it seems, but here's your change: http://hg.mozilla.org/mozilla-central/rev/3ee96c3879bc
I supposed it is fixed.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.