607046 - VendorID and AdapterID are 0000

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

About 4.4% of crashes don't have proper device ids. We should see what we can do about this.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

We can probably track this down by (ab)using the device_id to return a more specific error code.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

Attachment: Try to give some more visibility into what's going wrong here

This patch adds additional information to the crashdumps when we fail to get a proper vendor_id/device_id

Comment 3

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

You may want to append GetLastError() to the debug string as well, in case a call fails along the way.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Attachment: v2

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 486987 [details] [diff] [review]
v2

r=me with the moving of NullSearch as we discussed IRL.

maybe print mDeviceKeyDebug first for readability, since mDeviceID might be crazy?

Comment 6

[Jeff Muizelaar [:jrmuizel]]

http://hg.mozilla.org/mozilla-central/rev/765087b28561

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Sigh, sorry Jeff, qimport didn't preserve blame it seems, but here's your change:
http://hg.mozilla.org/mozilla-central/rev/3ee96c3879bc

Comment 8

[Scoobidiver (away)]

I supposed it is fixed.