60715 - My sidebar won't stay minimized

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[ltskinol]

Linux build: 200011906

(Please place in proper component - I wasn't sure which one was
right).

Reproducable: Always

Open the mail/news tool, view->My Sidebar is checked, so that the
tool is approximately divided into four panes:

1. Upper left - Mail Folders
2. Lower left - My Sidebar
3. Upper right - Message summaries
4. Bottom right = Message contents

Now click on the My Sidebar grippy.  My Sidebar is now minimized
and you only see a grippy in the lower left.

Close the mail tool, the re-open it.

Result: My Sidebar reappears.
Expected result: it should remain minimized.

Comment 1

[Keyser Sose]

I believe this was a problem in that nightly. Try one of the latest ones it
should work fine now. Marking as Worksforme. Reopen if you still see it in the
latest builds.

Comment 2

[Ninoschka Baca]

Build 2000-12-29-08: NT4, Linux 6.2, Mac 9.04
Reopening, the problem still occurs.

Also marking nsbeta1 because the Sidebar should remember its state.

Comment 3

[Ninoschka Baca]

Setting to New since it is reproduceable.

Comment 4

[scottputterman]

marking nsbeta1+ and moving to mozilla0.8 milestone.  Reassigning to sspitzer

Comment 5

[(not reading, please use [e-mail] instead)]

probably a dup of #64000

accepting until I know for sure.

Comment 6

[(not reading, please use [e-mail] instead)]

here's how I could see it being a duplicate of #64000:

start mozilla with -mail
minimize sidebar
exit

start mozilla with -mail
sidebar is not minimized

is that what you are seeing?

Comment 7

[Peter Lairo]

i'm getting the same wrong behaviour with the latest nightly.

Comment 8

[Ninoschka Baca]

Build 2001-010410: Linux 6.2

- Start with "netscape6" (without -mail)
- From the browser open mail
- Minimize the Sidebar by selecting the My Sidebar grippy
- Select File|Close so the browser appears again
- From the browser open mail
Results: The Sidebar is not minimized so it's different from bug# 64000 because
the browser is always open.

Comment 9

[(not reading, please use [e-mail] instead)]

from what nbaca told me, this doesn't sound related to #64000.

investigating...

Comment 10

[scottputterman]

reassigning to ssu

Comment 11

[Ninoschka Baca]

*** Bug 64358 has been marked as a duplicate of this bug. ***

Comment 12

[John Morrison]

From the other bug 64358:

------- Additional Comments From John Morrison 2001-01-04 17:26 -------

Here's a patch, but not sure if it's the right way to do things anymore. 

--- sidebarOverlay.js~  Tue Jan 02 12:23:02 2001
+++ sidebarOverlay.js   Tue Jan 02 20:11:18 2001
@@ -949,7 +949,8 @@
   // but wait until the last drag has been committed.
   // May want to do something smarter here like only force it if the 
   // height has really changed.
-  setTimeout("document.persist('sidebar-panels-splitter-box','height');",100);
+  setTimeout("document.persist('sidebar-panels-splitter-box','height');" + 
+             "document.persist('sidebar-panels-splitter-box','collapsed');", 
100);
 }
 
 function persist_width() {

Comment 13

[scottputterman]

moving to mozilla0.9

Comment 14

[jsnod]

I am seeing this as well on Win98 2001012904 ... started happening last week.

Comment 15

[Fabian Guisset]

Attachment: patch to persist mail and address book sidebar state

Comment 16

[Fabian Guisset]

Ok here is a simple (too simple?) patch to persist the state of the horizontal
splitter (between the folder pane and the sidebar content). I was told by Jag
that right now we're using setTimeout to persist state even when we crash.
That's all fine but I think it's abusing js ;) If we were to follow that logic
everywhere, the |persist=| attribute would be deprecated, cuz we would have to
use setTimeouts everywere.
Since this actually affects all the sidebars, it also fixes the bug about the
address book sidebar not remembering its state. 
I've tested it for a little while and haven't been able to find any secondary
effect to this change. Could those CC'ed on this bug test the patch on their builds?
CC'ing alecf and myself, not for review, but because I think you're the person
most likely to answer my question about setTimeout (since slamm who wrote the
original code is no longer there). Thanks.

Comment 17

[Alec Flett]

I still don't understand why we EVER need to use document.persist. Find ben or
hyatt on IRC and ask them... 

in any case, if this makes it work, then r=alecf! You'll need a mail person for sr=

Comment 18

[Fabian Guisset]

FYI the address book bug is bug 64302. It was mozilla0.8 but apparently futured
now. I'll try to find ben or hyatt, and if it turns out we don't need the
document.persist, i'll volunteer to get them out of our dear js files ;-)

Comment 19

[Fabian Guisset]

CCing some mail people for sr=, thanks guys.

Comment 20

[Håkan Waara]

This patch seems to make sense, and worked fine for me! r=hwaara

Comment 21

[Fabian Guisset]

Attachment: Valid patch against the current tree, courtesy of hwaara

Comment 22

[scottputterman]

marking nsbeta1- and moving to future milestone.

Comment 23

[Boris Zbarsky [:bzbarsky]]

Um... this bug has a patch and r=, it needs sr=.  Adding the corresponding
keywords.  Nominating.   The nsbeta- just means the Netscape engineer it's
assigned to should not be focusing on it.  In this case, since there is already
a patch this seems to be irrelevant....

Could a super-reviewer please take a look at this?

Comment 24

[David :Bienvenu]

sr=bienvenu

Comment 25

[Boris Zbarsky [:bzbarsky]]

Attachment: Last patch with cleaned-up whitespace so it applies nicely

Comment 26

[Fabian Guisset]

checked in -- thanks to everyone who helped :)

Comment 27

[Ninoschka Baca]

Build 2001-03-06-05: NT4, Linux RH 6.2
Verified Fixed, although bug# 64000 still occurs.