Update tests to use CommonJS [group 3]

RESOLVED FIXED

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: aaronmt, Assigned: aaronmt)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Assignee)

Description

8 years ago
Created attachment 485907 [details] [diff] [review]
Patch v1 - (default) [group 3]

This bug tracks CommonJS test changes to the following modules: 

[group 3]

* general: 2 
* layout: 1
* passwordmanager: 2
* popups: 2
* preferences: 5
* privatebrowsing: 9
* technicaltools: 1
Attachment #485907 - Flags: review?(gmealer)
(Assignee)

Updated

8 years ago
Blocks: 607106
No longer depends on: 602365
Blocks: 602365
No longer blocks: 607106
Summary: Update Tests to use CommonJS (part I) [group 3] → Update Tests to use CommonJS [group 3]
(Assignee)

Updated

8 years ago
Summary: Update Tests to use CommonJS [group 3] → Update tests to use CommonJS [group 3]
Comment on attachment 485907 [details] [diff] [review]
Patch v1 - (default) [group 3]

testGeneral/GoogleSuggestions.js needs to also change UtilsAPI within the code itself. 

testGeneral/testStopReloadButtons.js, and testLayout/testNavigateFTP.js don't actually seem to use UtilsAPI, so the require should just be removed. Double-check me on that though. If they are used in code, they need to be changed as well.

With those changes, r=me.
Attachment #485907 - Flags: review?(gmealer) → review-
One other thing, make sure you do a full test run on these before landing. I can check the changes you have made, but the danger is the ones you miss. Those are impossible to check for in review but a test run will find them. Thanks!
(Assignee)

Comment 3

8 years ago
Created attachment 486152 [details] [diff] [review]
Patch v1.1 - (default) [group 3] [checked in]

Yep, those three tests listed on default dont actually make use of those shared modules. Now removed in updated patch here. Looks like left overs from older branch conversion. Ran full test prior and again with this one, everything good.
(Assignee)

Updated

8 years ago
Attachment #486152 - Flags: review+
(Assignee)

Comment 4

8 years ago
Created attachment 486156 [details] [diff] [review]
Patch v1 - (1.9.2) [group 3]

1.9.2
Assignee: nobody → aaron.train
Status: NEW → ASSIGNED
Attachment #486156 - Flags: review?(gmealer)
(Assignee)

Comment 5

8 years ago
Created attachment 486157 [details] [diff] [review]
Patch v1 - (1.9.1) [group 3]

1.9.1
Attachment #486157 - Flags: review?(gmealer)
(Assignee)

Updated

8 years ago
Attachment #486152 - Attachment description: Patch v1.1 - (default) [group 3] → Patch v1.1 - (default) [group 3] [checked in]
(Assignee)

Updated

8 years ago
Attachment #485907 - Attachment is obsolete: true
Comment on attachment 486156 [details] [diff] [review]
Patch v1 - (1.9.2) [group 3]

Looks fine.
Attachment #486156 - Flags: review?(gmealer) → review+
Comment on attachment 486157 [details] [diff] [review]
Patch v1 - (1.9.1) [group 3]

Looks fine.
Attachment #486157 - Flags: review?(gmealer) → review+
Backports landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/bfadcadb6bab (1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/f2b882a618bd (1.9.1)
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Mozmill Tests → Mozmill Tests
Product: Testing → Mozilla QA
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.