607151 - Update tests to use CommonJS [group 3]

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (default) [group 3]

This bug tracks CommonJS test changes to the following modules: 

[group 3]

* general: 2 
* layout: 1
* passwordmanager: 2
* popups: 2
* preferences: 5
* privatebrowsing: 9
* technicaltools: 1

Comment 1

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 485907 [details] [diff] [review]
Patch v1 - (default) [group 3]

testGeneral/GoogleSuggestions.js needs to also change UtilsAPI within the code itself. 

testGeneral/testStopReloadButtons.js, and testLayout/testNavigateFTP.js don't actually seem to use UtilsAPI, so the require should just be removed. Double-check me on that though. If they are used in code, they need to be changed as well.

With those changes, r=me.

Comment 2

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

One other thing, make sure you do a full test run on these before landing. I can check the changes you have made, but the danger is the ones you miss. Those are impossible to check for in review but a test run will find them. Thanks!

Comment 3

[Aaron Train [:aaronmt]]

Attachment: Patch v1.1 - (default) [group 3] [checked in]

Yep, those three tests listed on default dont actually make use of those shared modules. Now removed in updated patch here. Looks like left overs from older branch conversion. Ran full test prior and again with this one, everything good.

Comment 4

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (1.9.2) [group 3]

1.9.2

Comment 5

[Aaron Train [:aaronmt]]

Attachment: Patch v1 - (1.9.1) [group 3]

1.9.1

Comment 6

[Aaron Train [:aaronmt]]

Default landed as http://hg.mozilla.org/qa/mozmill-tests/rev/bbe5aa081226

Comment 7

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 486156 [details] [diff] [review]
Patch v1 - (1.9.2) [group 3]

Looks fine.

Comment 8

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 486157 [details] [diff] [review]
Patch v1 - (1.9.1) [group 3]

Looks fine.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Backports landed as:
http://hg.mozilla.org/qa/mozmill-tests/rev/bfadcadb6bab (1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/f2b882a618bd (1.9.1)

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.