607219 - dynamic role attribute change on body doesn't affect on document role

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

try document.body.setAttribute("role", "application") and check the document role. 

Marco, can you check whether this is issue for Firefox 3.6?

Comment 1

[alexander :surkov (:asurkov)]

When we listen role attribute change then we should update roleMapEntry on the document if it was changed on document content element (nsCoreUtils::GetRoleContent). Now we recreate an accessible if the node with changed role attribute is accessible, neither body nor document is accessible so we ignore this notification.

David, wanna take this?

Comment 2

[alexander :surkov (:asurkov)]

asking blocking because ARIA toolkits tends to set role attribute on onload() event, at this point we have created document accessible and set up roleMapEntry.

Comment 3

[Marco Zehe (:MarcoZ)]

Doesn't work in Firefox 3.6 either. At least if I add your suggested statement to an onclick handler of an element, the accessible role of the document doesn't change in either Firefox 3.6.11 nor current Minefield.

Comment 4

[alexander :surkov (:asurkov)]

Yes, you understood right, that's one of ways to test it. Thank you.

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch

Comment 6

[David Bolter [:davidb] (NeedInfo me for attention)]

Locally I added a comment to the else clause:
   else {
      // Recreate the accessible because a role change is quite significant.
      RecreateAccessible(aContent);
    }
 

I'm not sure how to provide better details here.

Comment 7

[alexander :surkov (:asurkov)]

(In reply to comment #6)

> I'm not sure how to provide better details here.

something like that:

recreate an accessible when role is changed because we might use different accessible class for new role or accessible may expose different sets of interfaces (COM restriction).

Comment 8

[alexander :surkov (:asurkov)]

Comment on attachment 489258 [details] [diff] [review]
patch

r=me with comment fixed and mochitest added (ask Marco for additional review when tests are done).

Comment 9

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch 1.1

Comment 10

[Marco Zehe (:MarcoZ)]

Comment on attachment 489869 [details] [diff] [review]
patch 1.1

>+      document.body.setAttribute("role","application");

Nit: Please put  a space after the comma to separate the arguments.

r=me.

Comment 11

[David Bolter [:davidb] (NeedInfo me for attention)]

http://hg.mozilla.org/mozilla-central/rev/f1392194154c

Thanks all.

Comment 12

[David Bolter [:davidb] (NeedInfo me for attention)]

(In reply to comment #1)
> David, wanna take this?

Sure. ;)