Closed Bug 607219 Opened 9 years ago Closed 9 years ago

dynamic role attribute change on body doesn't affect on document role

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b8
Tracking Status
blocking2.0 --- final+

People

(Reporter: surkov, Assigned: davidb)

References

(Blocks 1 open bug)

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

try document.body.setAttribute("role", "application") and check the document role. 

Marco, can you check whether this is issue for Firefox 3.6?
When we listen role attribute change then we should update roleMapEntry on the document if it was changed on document content element (nsCoreUtils::GetRoleContent). Now we recreate an accessible if the node with changed role attribute is accessible, neither body nor document is accessible so we ignore this notification.

David, wanna take this?
asking blocking because ARIA toolkits tends to set role attribute on onload() event, at this point we have created document accessible and set up roleMapEntry.
blocking2.0: --- → ?
Doesn't work in Firefox 3.6 either. At least if I add your suggested statement to an onclick handler of an element, the accessible role of the document doesn't change in either Firefox 3.6.11 nor current Minefield.
Yes, you understood right, that's one of ways to test it. Thank you.
blocking2.0: ? → final+
Assignee: nobody → bolterbugz
Attached patch patch (obsolete) — Splinter Review
Attachment #489258 - Flags: review?(surkov.alexander)
Locally I added a comment to the else clause:
   else {
      // Recreate the accessible because a role change is quite significant.
      RecreateAccessible(aContent);
    }
 

I'm not sure how to provide better details here.
(In reply to comment #6)

> I'm not sure how to provide better details here.

something like that:

recreate an accessible when role is changed because we might use different accessible class for new role or accessible may expose different sets of interfaces (COM restriction).
Comment on attachment 489258 [details] [diff] [review]
patch

r=me with comment fixed and mochitest added (ask Marco for additional review when tests are done).
Attachment #489258 - Flags: review?(surkov.alexander) → review+
Attached patch patch 1.1Splinter Review
Attachment #489258 - Attachment is obsolete: true
Attachment #489869 - Flags: review?(marco.zehe)
Comment on attachment 489869 [details] [diff] [review]
patch 1.1

>+      document.body.setAttribute("role","application");

Nit: Please put  a space after the comma to separate the arguments.

r=me.
Attachment #489869 - Flags: review?(marco.zehe) → review+
http://hg.mozilla.org/mozilla-central/rev/f1392194154c

Thanks all.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
(In reply to comment #1)
> David, wanna take this?

Sure. ;)
Flags: in-testsuite+
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.