607287 - Crash when trying to disable or uninstall an add-on [@ nsWindow::UserActivity]

Status: RESOLVED FIXED

(Core Graveyard :: Widget: Android, defect)

Description

[Ioana Chiorean]

Device: Samsung Galaxy S Captive- SGH-I897
Build Identifier: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b8pre)Gecko/20101025
Firefox/4.0b8pre Fennec /4.0b2pre 

Steps to reproduce:
1. Open Fennec -> install an add-on like: Twitter Bar, Reading list.
2. Go to Addons Manager and press disable at one of them 
3. At the blue notification with Restart, press Restart

Expected results:
- Application should restart and the add-on should be visible disabled

Actual results:
- when pressing Restart the application freezes and returns in a crash . 

Crash report available here:
http://crash-stats.mozilla.com/report/index/bp-e704987a-b008-436e-937b-0ba1b2101026

Comment 1

[Ioana Chiorean]

same behavior for uninstall also -> crash

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Was this fixed by bug 606178?

Comment 3

[Ioana Chiorean]

This is strange because only on the mentioned device occurs,and doesn't occur on Android 2.1 (HTC Desire), Android 2.2 (Motorola Droid 2) and Maemo (N900)

Comment 4

[Ioana Chiorean]

Also, it occurs on the 10/25 build and not on a previous one (the bug 606178 ) reproduced on all android since build 10/24

Comment 5

[Aakash Desai [:aakashd]]

I'll check this out once the builds are up

Comment 6

[timeless]

Signature	nsWindow::UserActivity
UUID	e704987a-b008-436e-937b-0ba1b2101026
Time 	2010-10-26 06:08:44.900058
Uptime	39
Last Crash	183 seconds (3.0 minutes) before submission
Install Age	7365 seconds (2.0 hours) since version was first installed.
Product	Fennec
Version	4.0b2pre
Build ID	20101025041936
Branch	2.0
OS	Linux
OS Version	0.0.0 Linux 2.6.29 #2 Sun Jun 27 15:49:12 KST 2010 armv7l
CPU	arm
CPU Info	
Crash Reason	SIGSEGV
Crash Address	0x9c
Email Address	
URL	
User Comments	
Processor Notes 	
EMCheckCompatibility	False
Crashing Thread
Frame 	Module 	Signature [Expand] 	Source
0 	libxul.so 	nsWindow::UserActivity 	nsCOMPtr.h:800
1 	libxul.so 	nsWindow::OnGlobalAndroidEvent 	nsTArray.h:66
2 	libxul.so 	nsAppShell::ProcessNextNativeEvent 	widget/src/android/nsAppShell.cpp:295
3 	libxul.so 	nsBaseAppShell::DoProcessNextNativeEvent 	widget/src/xpwidgets/nsBaseAppShell.cpp:162
4 	libxul.so 	nsBaseAppShell::OnProcessNextEvent 	widget/src/xpwidgets/nsBaseAppShell.cpp:305
5 	libxul.so 	mozilla::dom::ContentParent::OnProcessNextEvent 	dom/ipc/ContentParent.cpp:563
6 	libxul.so 	nsThread::ProcessNextEvent 	xpcom/threads/nsThread.cpp:519
7 	libxul.so 	NS_ProcessNextEvent_P 	nsThreadUtils.cpp:250
8 	libxul.so 	nsThread::Shutdown 	xpcom/threads/nsThread.cpp:476
9 	libxul.so 	nsCacheService::Shutdown 	nsCOMPtr.h:492
10 	libxul.so 	nsCacheProfilePrefObserver::Observe 	netwerk/cache/nsCacheService.cpp:364
11 	libxul.so 	nsObserverList::NotifyObservers 	nsVoidArray.h:63
12 	libxul.so 	nsObserverService::NotifyObservers 	nsTHashtable.h:170
13 	libxul.so 	mozilla::ShutdownXPCOM 	xpcom/glue/nsCOMPtr.h:492
14 	libxul.so 	NS_ShutdownXPCOM_P 	xpcom/build/nsXPComInit.cpp:588
15 	libxul.so 	ScopedXPCOMStartup::~ScopedXPCOMStartup 	toolkit/xre/nsAppRunner.cpp:1118
16 	libxul.so 	XRE_main 	nsCOMPtr.h:800
17 	libxul.so 	GeckoStart 	toolkit/xre/nsAndroidStartup.cpp:131
18 	libc.so 	libc.so@0xfdd7 	
19 	libc.so 	libc.so@0xf8a3

Comment 8

[Aakash Desai [:aakashd]]

This is working for me after upgrading to 10/26 (today) nightly build. There is one crash that happened on today's nightly builds though.

http://crash-stats.mozilla.com/report/index/ca814faf-d818-458b-8a0d-71de42101026

Comment 9

[Ioana Chiorean]

It also reproduced today:
Device: Samsung Galaxy S Captive- SGH-I897
Build Identifier: Mozilla /5.0 (Android;Linux armv7l;rv:2.0b8pre)Gecko/20101027
Firefox/4.0b8pre Fennec /4.0b2pre

Comment 10

[Doug Turner (:dougt)]

Attachment: patch v.1

It looks like nsWindow::Destroy() is be called, and events are still coming into this method from the appshell.  In some places we were testing for null, others not so much :(

Comment 11

[Michael Wu [:mwu]]

Comment on attachment 486384 [details] [diff] [review]
patch v.1

Post checkin r+.

Comment 12

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/2ee46939bb9e