Closed
Bug 607293
Opened 15 years ago
Closed 15 years ago
JM: Turn SETELEM into an IC
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dvander, Assigned: dvander)
References
Details
(Whiteboard: fixed-in-tracemonkey)
Attachments
(1 file, 1 obsolete file)
|
15.97 KB,
patch
|
dmandelin
:
review+
|
Details | Diff | Splinter Review |
Like the GETELEM refactoring, this will split all of the excess fast-paths into ICs (there appears to be only one), and introduce a new IC type. It should be simpler though, since for this one we don't care about string keys yet.
|
Assignee | |
Comment 1•15 years ago
|
||
Tests caught some bugs along the way - amusingly, even an ES5 compliance bug which Jeff tells me is known ([].hasOwnProperty apparently lies with indexed setters)
This is about a reproducible 1-2ms win on access-fannkuch. Register use is a little better and indexed property checking dropped a bunch of loads.
Attachment #486550 -
Flags: review?(dmandelin)
|
|
Assignee | |
Comment 2•15 years ago
|
||
Attachment #486550 -
Attachment is obsolete: true
Attachment #486551 -
Flags: review?(dmandelin)
Attachment #486550 -
Flags: review?(dmandelin)
|
||
Updated•15 years ago
|
Attachment #486551 -
Flags: review?(dmandelin) → review+
|
|
Assignee | |
Comment 3•15 years ago
|
||
Whiteboard: fixed-in-tracemonkey
|
||
Comment 4•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•