607316 - Run set toolsdir only once

Status: RESOLVED WORKSFORME

(Release Engineering :: General, defect, P4)

Description

[Armen [:armenzg]]

Attachment: call set toolsdir only once

We run this command twice for Windows jobs and we override in every class subclassing MozillaBuildFactory.

The attached patch fixes the step in MozillaBuildFactory so there is no need to override the step in all subclassing factories.

This also fixes the scenario for Win64.

Comment 1

[[e-mail] (:bhearsum)]

Comment on attachment 486062 [details] [diff] [review]
call set toolsdir only once

I don't think self.platform exists at this point...have you tested this?

Comment 2

[Armen [:armenzg]]

Comment on attachment 486062 [details] [diff] [review]
call set toolsdir only once

Let me make sure that the patch works.
The checkconfigs I run where working but on staging is not taking it as is.

More to come.

Comment 3

[Armen [:armenzg]]

I have put up a patch to fix the Win64 issue in bug 565402. Sorry if my testing scripts on my local machine made me think I had a good patch for review.

Would you be fine WONTFIXing this bug even if it is valid? (meaning that we should not spend time trying to fix and test this small bug)

Comment 4

[Chris Cooper [:coop] (he/him)]

(In reply to comment #3)
> Would you be fine WONTFIXing this bug even if it is valid? (meaning that we
> should not spend time trying to fix and test this small bug)

Let's not punt on everything. This is the kind of bug that's perfect for new hires.

Comment 5

[[e-mail] (:bhearsum)]

(In reply to comment #4)
> (In reply to comment #3)
> > Would you be fine WONTFIXing this bug even if it is valid? (meaning that we
> > should not spend time trying to fix and test this small bug)
> 
> Let's not punt on everything. This is the kind of bug that's perfect for new
> hires.

Agreed, and I don't think we should WONTFIX. It's just low priority.