607331 - Add-ons menu item should spawn new window if one does not exist

Status: VERIFIED DUPLICATE of bug 565667

(Firefox :: Menus, defect)

Description

[dean.wyatte]

User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b6) Gecko/20100101 Firefox/4.0b6
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b6) Gecko/20100101 Firefox/4.0b6

This only affects the Mac platform (I think) since Firefox is allowed to run without a window open.

If a user clicks the Tools > Add-ons menu item without the browser window open, nothing happens. Should be an easy fix. 

Reproducible: Always

Steps to Reproduce:
1. Start Firefox.
2. Close main window.
3. Click Tools > Add-ons.
Actual Results:  
Nothing happens.

Expected Results:  
The behavior should be the same as when a window already exists. The Add-ons tab should appear as a new tab in a browser window regardless of whether the window already exists.

Comment 1

[Stefan [:stefanh]]

Callek, iirc you have a fix for this.

Comment 2

[Justin Wood (:Callek)]

Yea, I fixed this for SeaMonkey... I'll look up what I did and get this done. Nomming for blocking-final.

Comment 4

[Dietrich Ayala (:dietrich)]

Menu items that do nothing when clicked are bad. Blocking+.

Comment 5

[Justin Wood (:Callek)]

Attachment: v1

gavin, you mentioned in Bug 586360 that you are giving r+ on this patch if I wanted to port it.

However I suspect the differences between SeaMonkeys |if (aOpenNew)| and Firefox's may make this change alone not enough... (I can't test on mac to verify though)

Comment 6

[:Gavin Sharp [email: [e-mail]]]

This is already covered by bug 565667.

Comment 7

[Justin Wood (:Callek)]

o heh, ok.