Closed Bug 607447 Opened 9 years ago Closed 9 years ago

JavaScript error: chrome://browser/content/input.js, line 481: parentNode is null (about:config)

Categories

(Firefox for Android Graveyard :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(fennec2.0+)

VERIFIED FIXED
Tracking Status
fennec 2.0+ ---

People

(Reporter: mfinkle, Assigned: wesj)

Details

Attachments

(1 file, 1 obsolete file)

I get the above error when tapping on a toggle button in about:config. The toggle does not change state. Tapping again works and no error is produced.
Assignee: nobody → mbrubeck
FWIW:

The first click generates a MouseEvent with originalTarget of a XULDocument. The XULDocument has baseURI : about:config. This has no parentNode.

The second (working) click generates a MouseEvent with originalTarget of an HTMLDivElement, and another MouseEvent with originalTarget of a XULElement. Both of these have a parentNode.
tracking-fennec: --- → 2.0+
Summary: JavaScript error: chrome://browser/content/input.js, line 481: parentNode is null → JavaScript error: chrome://browser/content/input.js, line 481: parentNode is null (about:config)
Removing the insertBefore line at:

http://mxr.mozilla.org/mobile-browser/source/chrome/content/config.js#168

fixes this (although it breaks about:config as well). Something about moving this node is causing the next event to be retargeted on the document. We could do a few different things if we just want to kill the call. Rewrite about:config to use setting elements, or attach an editor row to every item in the list rather than moving this one around.
Attached patch Fix (obsolete) — Splinter Review
Vivien helped come up with this fix. Apparently we're hitting some race condition with something else watching for select. Wrapping in a setTimeout fixes things.
Attachment #498018 - Flags: review?
Comment on attachment 498018 [details] [diff] [review]
Fix

move to a member function
Attached patch finkled patchSplinter Review
Moved this into its own function.
Attachment #498018 - Attachment is obsolete: true
Attachment #498021 - Flags: review?
Attachment #498018 - Flags: review?
Attachment #498021 - Flags: review? → review+
pushed:
http://hg.mozilla.org/mobile-browser/rev/ba5752da717a
Assignee: mbrubeck → wjohnston
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Verified fixed, using:
Mozilla/5.0 (Maemo; Linux armv7l; rv:2.0b9pre) Gecko/20101227 Firefox/4.0b9pre Fennec/4.0b4pre ID:20101227013355
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.