607524 - on page with long <title>, click bookmark star twice and after a few seconds firefox distorts

Status: NEW

(Toolkit :: Places, defect, P5)

Description

[Travis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US) AppleWebKit/534.7 (KHTML, like Gecko) Chrome/7.0.517.41 Safari/534.7
Build Identifier: 3.6.10

I created a webpage with a large header. Once i viewed the page and it loaded i clicked the bookmark star two times which it then distorts firefox.

Reproducible: Always

Steps to Reproduce:
1.go to a webpage with a big header. I made http://www.thegameisserious.com/testtest.htm
2.click the bookmark star to bookmark
3.click the bookmark star again to edit
4.wait about 15 seconds, and you will see the result
Actual Results:  
firefox gets all messed up, and doesn't show the bookmark editor. or any of the right menu names.

Expected Results:  
show the bookmark editor, and not mess up.

Even if you close firefox and open it again, it will still be messed up.

Comment 1

[Travis]

seems like after i upgrade to 3.6.11 the file menu doesn't distort when clicking bookmark, but if you click new tab the tabs menu gets distorted.

Comment 2

[Daniel Veditz [:dveditz]]

The document has a <title> that is 9,376,093 characters long. Firefox noticeably bogs down trying to deal with it, but I haven't yet reproduced the original problem (on trunk, haven't tried FF3.6 yet).

The "Show all bookmarks..." dialog is somewhat messed up. Shorter names get an ellipsis when they're too long for the column, but this bad boy just keep going without regard for the column boundary and draws on top of values in other columns such as the location.

Comment 3

[Shawn Wilsher :sdwilsh]

(In reply to comment #2)
> The document has a <title> that is 9,376,093 characters long. Firefox
> noticeably bogs down trying to deal with it, but I haven't yet reproduced the
> original problem (on trunk, haven't tried FF3.6 yet).
Same here on trunk.

Comment 4

[Daniel Veditz [:dveditz]]

It's "Organize Bookmarks" in Firefox 3.6, but otherwise I see the same effects. I don't see the menus get messed up, but I've been testing on Mac and it looks like you're using Windows 7 if your user agent is to be believed.

Comment 5

[Daniel Veditz [:dveditz]]

On Windows 7 I see the same issues with the Bookmarks dialog on 3.6.11 and trunk as I do on Mac. The Tab behavior is a little different. On Mac the tab was simply blank, it didn't show any part of the document title; on Windows 7 the title overflowed the tab and wrote on top of any tabs to the right, very similar to the way it was not correctly truncated in the Bookmark dialog.

On both platforms the "name" text box was blank when I brought up the Edit Bookmark dialog by clicking on the star, and blank in the editing box at the bottom of the Organize Bookmarks dialog when I selected the bookmark. There was definitely an abundance of name up in the table part of that dialog.

I'm confirming there's a visual bug here, but it does not appear to be a security problem.

Comment 6

[Daniel Veditz [:dveditz]]

Attachment: testcase (zipped)

Preserving the testcase in case the page goes away.

Comment 7

[Daniel Veditz [:dveditz]]

Can we simply cap insane values at some reasonable size? How many times longer than what the largest display in the world can show do we need to support?

Comment 8

[Shawn Wilsher :sdwilsh]

(In reply to comment #7)
> Can we simply cap insane values at some reasonable size? How many times longer
> than what the largest display in the world can show do we need to support?
We could cap; I don't see why that would be a problem.

Comment 9

[Marco Bonardo [:mak]]

I suspect History.cpp is cropping the title stored to the database but not cropping the title notified to observers.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

In the process of migrating remaining bugs to the new severity system, the severity for this bug cannot be automatically determined. Please retriage this bug using the new severity system.

Comment 11

[Marco Bonardo [:mak]]

We should investigate if comment 9 is correct, if the bug as reported is still happening, and also check if we can limit titles in the bookmark dialogs or more in general in bookmarks (I suspect we already do, but must be verified).

It would also be interesting to check our bookmark urls limit considering we allow data uris of up to 32MB per https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/Data_URLs