remove support of accessibility.disablecache preference

RESOLVED FIXED in mozilla2.0b8

Status

()

Core
Disability Access APIs
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

({access, dev-doc-complete})

unspecified
mozilla2.0b8
access, dev-doc-complete
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

2.73 KB, patch
MarcoZ
: review+
Benjamin Smedberg
: approval2.0+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Created attachment 486258 [details] [diff] [review]
patch

It's not honored any more (we cache accessibles, get them from cache, the only affect it has we always invalidate children when AT asks for children, that's not disabled cache really) and not used I think. http://kb.mozillazine.org/Accessibility.disablecache says is mostly for debugging propose.
Attachment #486258 - Flags: review?(marco.zehe)
Attachment #486258 - Flags: approval2.0?
(Assignee)

Comment 1

7 years ago
Created attachment 486262 [details] [diff] [review]
patch2

previous patch was wrong
Assignee: nobody → surkov.alexander
Attachment #486258 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #486262 - Flags: review?(marco.zehe)
Attachment #486262 - Flags: approval2.0?
Attachment #486258 - Flags: review?(marco.zehe)
Attachment #486258 - Flags: approval2.0?

Comment 2

7 years ago
Comment on attachment 486262 [details] [diff] [review]
patch2

r=me. But is there some JS file that also has this pref defined where we need to remove it? E. G. this once showed up in about:config, right? So ti must be defined in some prefs.js file or the like. Please check before landing and remove it there, too.
Attachment #486262 - Flags: review?(marco.zehe) → review+
(Assignee)

Comment 3

7 years ago
It isn't referred anywhere outside of a11y, it isn't presented in about:config.

Comment 4

7 years ago
All right, thanks for checking! So this is completely useless code now. :) Yeah, let's ditch it! Thanks for finding!

Updated

7 years ago
Attachment #486262 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 5

7 years ago
Benjamin, am I allowed to land it while tree is restricted to Gecko 2 beta 7 blockers?

Comment 6

7 years ago
No.
(Assignee)

Comment 7

7 years ago
landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/7f42cc721784
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
(Assignee)

Updated

7 years ago
Keywords: dev-doc-needed
This isn't already documented anywhere on MDC, but I added a note to Fx4 for developers:

https://developer.mozilla.org/en/Firefox_4_for_developers#Other_changes
Keywords: dev-doc-needed → dev-doc-complete
(Assignee)

Comment 9

7 years ago
Yes, thank you. Perhaps it makes sense to update article on http://kb.mozillazine.org. I just don't know who is responsible for it.
You need to log in before you can comment on or make changes to this bug.