607538 - remove support of accessibility.disablecache preference

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

Attachment: patch

It's not honored any more (we cache accessibles, get them from cache, the only affect it has we always invalidate children when AT asks for children, that's not disabled cache really) and not used I think. http://kb.mozillazine.org/Accessibility.disablecache says is mostly for debugging propose.

Comment 1

[alexander :surkov (:asurkov)]

Attachment: patch2

previous patch was wrong

Comment 2

[Marco Zehe (:MarcoZ)]

Comment on attachment 486262 [details] [diff] [review]
patch2

r=me. But is there some JS file that also has this pref defined where we need to remove it? E. G. this once showed up in about:config, right? So ti must be defined in some prefs.js file or the like. Please check before landing and remove it there, too.

Comment 3

[alexander :surkov (:asurkov)]

It isn't referred anywhere outside of a11y, it isn't presented in about:config.

Comment 4

[Marco Zehe (:MarcoZ)]

All right, thanks for checking! So this is completely useless code now. :) Yeah, let's ditch it! Thanks for finding!

Comment 5

[alexander :surkov (:asurkov)]

Benjamin, am I allowed to land it while tree is restricted to Gecko 2 beta 7 blockers?

Comment 6

[Benjamin Smedberg]

No.

Comment 7

[alexander :surkov (:asurkov)]

landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/7f42cc721784

Comment 8

[Eric Shepherd [:sheppy]]

This isn't already documented anywhere on MDC, but I added a note to Fx4 for developers:

https://developer.mozilla.org/en/Firefox_4_for_developers#Other_changes

Comment 9

[alexander :surkov (:asurkov)]

Yes, thank you. Perhaps it makes sense to update article on http://kb.mozillazine.org. I just don't know who is responsible for it.