Move updateOptionItems() call from xul to js

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
MailNews: Composition
--
trivial
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

Trunk
seamonkey2.1b2
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

7 years ago
Sync' with Thunderbird, in order to ease bug 537219, etc.

Port "backend" code part of
http://bonsai.mozilla.org/cvsquery.cgi?module=ThunderbirdTinderbox&sortby=Date&hours=2&date=explicit&mindate=2003-08-03+23%3A36&maxdate=2003-08-03+23%3A36
"Add a new quote button for quoting the selected message like Netscape 4.x"

NB: We might want to actually add a button too, but I'll leave that to someone else in another bug.
(Assignee)

Comment 1

7 years ago
Created attachment 486315 [details] [diff] [review]
(Av1) Just copy Thunderbird code
[Checked in: Comment 2]

Please double-check: I'm just assuming this is good (enough) for SeaMonkey too.
Attachment #486315 - Flags: review?(iann_bugzilla)

Updated

7 years ago
Attachment #486315 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 2

7 years ago
Comment on attachment 486315 [details] [diff] [review]
(Av1) Just copy Thunderbird code
[Checked in: Comment 2]

http://hg.mozilla.org/comm-central/rev/4d6d44d653f4
Attachment #486315 - Attachment description: (Av1) Just copy Thunderbird code → (Av1) Just copy Thunderbird code [Checked in: Comment 2]
(Assignee)

Updated

7 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2

Comment 3

7 years ago
If you start by composing a new message, then open the 3pane window and select a message, the quote message menuitem remains disabled.

If you reply to a message, then close the 3pane window, the quote message menuitem remains enabled.

In both cases you can work around it by clicking in and out of the message body.
(Assignee)

Updated

7 years ago
Depends on: 609926
(Assignee)

Comment 4

7 years ago
(In reply to comment #3)

Right! (I kind of expected some issue like these :-/) I filed bug 609926 :-<

I see two options ftb:
*backout my port patch, reopen this bug then wait for bug 609926 to be fixed first.
*keep this regression, proceed with bug 537219, then synchronize again when bug 609926 is fixed.

What do you prefer?

Comment 5

7 years ago
In this sort of case there are several considerations to take into account. If the patch has only affected the nightlies, then this would suggest that it would be easier to back it out now and fix bug 537219 later. If this regression has been released, then it may be easier to fix bug 537219 now, especially if you don't know what the fix for bug 609926 might be.
(Assignee)

Comment 6

7 years ago
"blocking-seamonkey2.1=?":
Just to remember to back this out for SM 2.0b2 if bug 609926 hasn't been fixed (and copied) by then.
Status: RESOLVED → REOPENED
blocking-seamonkey2.1: --- → ?
Resolution: FIXED → ---
(Assignee)

Comment 7

7 years ago
Created attachment 490700 [details] [diff] [review]
(Bv1) Revert MsgComposeCommands.js part of patch Av1, Port bug 609926 fix instead
[Checked in: Comment 9]
Attachment #490700 - Flags: review?(iann_bugzilla)
(Assignee)

Updated

7 years ago
Summary: Merge updateOptionItems() into updateComposeItems() → Move updateOptionItems() call from xul to js

Comment 8

7 years ago
Comment on attachment 490700 [details] [diff] [review]
(Bv1) Revert MsgComposeCommands.js part of patch Av1, Port bug 609926 fix instead
[Checked in: Comment 9]

>     // Options Menu
>     goUpdateCommand("cmd_spelling");
>-    goUpdateCommand("cmd_quoteMessage");
In the TB patch you add a call to updateOptionItems() here, why not for SM?

r=me with that explained/addressed.
Attachment #490700 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 9

7 years ago
Comment on attachment 490700 [details] [diff] [review]
(Bv1) Revert MsgComposeCommands.js part of patch Av1, Port bug 609926 fix instead
[Checked in: Comment 9]

http://hg.mozilla.org/comm-central/rev/ec3138bfe33a


(In reply to comment #8)
> In the TB patch you add a call to updateOptionItems() here, why not for SM?

SM doesn't need that workaround (anymore), as SM doesn't have a 'Quote' button (yet).
Attachment #490700 - Attachment description: (Bv1) Revert MsgComposeCommands.js part of patch Av1, Port bug 609926 fix instead → (Bv1) Revert MsgComposeCommands.js part of patch Av1, Port bug 609926 fix instead [Checked in: Comment 9]
(Assignee)

Updated

7 years ago
Status: REOPENED → RESOLVED
blocking-seamonkey2.1: ? → ---
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.