607592 - missing unittest builders for 1.9.2 releases

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

We've got unittestPlatforms = ('linux', 'macosx', 'win32') in the 1.9.2 release config but we don't have unittest builders on the build machines. 3.6.11 claims to seen unittests: https://wiki.mozilla.org/Releases/Firefox_3.6.11/BuildNotes#Unittests_2 so that would make this a fairly recent regression.

Comment 1

[[e-mail] (:bhearsum)]

bug 588546 looks suspicious, but it landed way back in August, so it seems unlikely that it's the cause.

Comment 2

[Chris AtLee [:catlee]]

bisect finds this as the first revision where we lost the unittests:

changeset:   3133:13898287789a
user:        Armen Zambrano Gasparnian <[e-mail]>
date:        Thu Oct 14 15:02:19 2010 -0400
summary:     Bug 596259. Beta7 staging fixes and syncing PLATFORM_VARS between mozilla/config.py and mozilla2/config.py. r=bhearsum

Comment 3

[Chris Cooper [:coop] (he/him)]

Looking at attachment 483214 [details] [diff] [review] attached to bug 596259, the patch does two things in mozilla2/config.py:

'enable_opt_unittests': False

and

'enable_unittests': False

Do we import the main config for releases and then not check/override these vars?

Comment 4

[Chris Cooper [:coop] (he/him)]

Armen: it was your patch that changed this. Can you figure out why, and how we can fix it? 

We may need to override the enable_*unittests vars for releases.

Comment 5

[Armen [:armenzg]]

OK I will get to this soon.

Just to rephrase explicitly what is supposed to happen for releases:
* 1.9.2 and 1.9.1 should run on the *builders*
* m-c (2.0) should run on the *minis*

Comment 6

[Armen [:armenzg]]

Attachment: enable_opt_unittests for 1.9.2 releases

Comment 7

[Armen [:armenzg]]

Attachment: diff between old config.py and new one

This file does not require a review but it shows the difference after applying the previous review.

Comment 8

[Armen [:armenzg]]

This seems to have got fixed somewhere when upgrading releases to 0.8.x in bug 553300.

I see the following builders:
release-mozilla-1.9.2-linux_test mochitests
release-mozilla-1.9.2-linux_test mochitest-other
release-mozilla-1.9.2-linux_test reftest
release-mozilla-1.9.2-linux_test crashtest
release-mozilla-1.9.2-linux_test xpcshell
release-mozilla-1.9.2-win32_test mochitests
release-mozilla-1.9.2-win32_test mochitest-other
release-mozilla-1.9.2-win32_test reftest
release-mozilla-1.9.2-win32_test crashtest
release-mozilla-1.9.2-win32_test xpcshell
release-mozilla-1.9.2-macosx_test mochitests
release-mozilla-1.9.2-macosx_test mochitest-other
release-mozilla-1.9.2-macosx_test reftest
release-mozilla-1.9.2-macosx_test crashtest
release-mozilla-1.9.2-macosx_test xpcshell