Closed Bug 607708 Opened 10 years ago Closed 10 years ago

A second download of an update is cached so we should simply check for the finished wizard page

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

Details

Attachments

(2 files)

We are caching downloaded updates locally. That means for the direct update test-run after a fallback test-run we do not see the downloading wizard page. Right now we don't take this into account.

Patch upcoming.
If we do not see the downloading page, we will have to check for the finished page instead.
Attachment #486393 - Flags: review?(aaron.train)
Comment on attachment 486393 [details] [diff] [review]
Patch v1 (1.9.2 + default)

Assuming it's tested, otherwise good to go r+
Attachment #486393 - Flags: review?(aaron.train) → review+
Attached patch Patch v1 (1.9.1)Splinter Review
The 1.9.1 version is a bit different because on this branch we haven't updated the API yet. :( I had to add two functions to make it possible to fix this specific bug.
Attachment #486407 - Flags: review?(gmealer)
Comment on attachment 486407 [details] [diff] [review]
Patch v1 (1.9.1)

LGTM
Attachment #486407 - Flags: review?(gmealer) → review+
Both patches have been landed (on 1.9.2 it works perfectly):
http://hg.mozilla.org/qa/mozmill-tests/rev/cdcb6a96c8a8 (1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/18134d50cc94 (1.9.1)

We also need this patch for default.
The patch for 1.9.2 applied cleanly on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/82f69d23a2b4

Marking as resolved fixed. Thanks for the quick reviews.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Attachment #486393 - Attachment description: Patch v1 (1.9.2) → Patch v1 (1.9.2 + default)
Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Product: Testing → Mozilla QA
Version: Trunk → unspecified
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.