607708 - A second download of an update is cached so we should simply check for the finished wizard page

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We are caching downloaded updates locally. That means for the direct update test-run after a fallback test-run we do not see the downloading wizard page. Right now we don't take this into account.

Patch upcoming.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1 (1.9.2 + default)

If we do not see the downloading page, we will have to check for the finished page instead.

Comment 2

[Aaron Train [:aaronmt]]

Comment on attachment 486393 [details] [diff] [review]
Patch v1 (1.9.2 + default)

Assuming it's tested, otherwise good to go r+

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Patch v1 (1.9.1)

The 1.9.1 version is a bit different because on this branch we haven't updated the API yet. :( I had to add two functions to make it possible to fix this specific bug.

Comment 4

[Geo Mealer [:geo] -- This account is inactive after 2015-07-07]

Comment on attachment 486407 [details] [diff] [review]
Patch v1 (1.9.1)

LGTM

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Both patches have been landed (on 1.9.2 it works perfectly):
http://hg.mozilla.org/qa/mozmill-tests/rev/cdcb6a96c8a8 (1.9.2)
http://hg.mozilla.org/qa/mozmill-tests/rev/18134d50cc94 (1.9.1)

We also need this patch for default.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The patch for 1.9.2 applied cleanly on default:
http://hg.mozilla.org/qa/mozmill-tests/rev/82f69d23a2b4

Marking as resolved fixed. Thanks for the quick reviews.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Move of Mozmill Test related project bugs to newly created components. You can
filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.