Closed Bug 607724 Opened 15 years ago Closed 15 years ago

TM: Create internal GetGlobalForScopeChain

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: cdleary, Assigned: cdleary)

Details

(Whiteboard: fixed-in-tracemonkey)

Attachments

(1 file)

Followup to bug 601299 -- some simple cleanup to put our GetGlobal family of functions into the js namespace / context methods.
Attached patch Cleanup.Splinter Review
Also adds a CHECK_REQUEST to JS_GetGlobalForScopeChain
Attachment #486426 - Flags: review?
Attachment #486426 - Flags: review? → review?(mrbkap)
Comment on attachment 486426 [details] [diff] [review] Cleanup. >+inline js::RegExpStatics * >+JSContext::regExpStatics() >+{ >+ JSObject *global = js::GetGlobalForScopeChain(this); >+ js::RegExpStatics *res = js::RegExpStatics::extractFrom(global); >+ return res; Nit: res isn't needed and I think this still fits on one line without global either. r=me with that
Attachment #486426 - Flags: review?(mrbkap) → review+
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: