607886 - Due to caching, possible to end up with invalid versions for a given product, which results in 404s/broken links

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

1. Load http://crash-stats.stage.mozilla.com/topcrasher/bytopsite/Firefox/3.6.9
2. Now choose "Thunderbird" from Product (you'll end up at http://crash-stats.stage.mozilla.com/products/Thunderbird with "Thunderbird" selected)
3. Now, hit the Back button, and you'll end up at http://crash-stats.stage.mozilla.com/topcrasher/bytopsite/Firefox/3.6.9 with "Thunderbird" still selected
4. At this point, choose anything from the "Current Verrsions" select widget

Expected:

"Firefox" product is cleared, and we use "Thunderbird", instead

Actual:

You'll end up with Franken-URLs like so: http://crash-stats.stage.mozilla.com/products/Firefox/versions/3.2a1pre (Firefox product, but Thunderbird versions)

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Dave/Vishal -- this is probably a prime candidate for a Selenium test in Python, since it uses a real browser.

Comment 2

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Reducing bug severity because most users of Socorro stay within one single project.

Comment 3

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Attachment: Patch 1 for 607886

Attachment ensures that cache is flushed every time the branches data admin page is loaded.  Flushes cache associated with data on the page, as well as within the nav bar.

Comment 4

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

Committing to the 1.7.7 branch.  This will not be available for testing until stage is on 1.7.7.

==

Sending        webapp-php/application/controllers/admin.php
Sending        webapp-php/application/libraries/MY_Controller.php
Sending        webapp-php/application/libraries/MY_Model.php
Sending        webapp-php/application/models/branch.php
Transmitting file data ....
Committed revision 2886.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

The same steps, though starting with Firefox 3.6.12's top crashers by site URL (https://crash-stats.stage.mozilla.com/topcrasher/bytopsite/Firefox/3.6.12, selecting Thunderbird, then clicking the browser's back button), returns a 500 error:

[14:08:26.411] GET https://crash-stats.stage.mozilla.com/products/Firefox [HTTP/1.1 200 OK 116ms]
[14:08:26.603] GET https://crash-stats.stage.mozilla.com/css/screen.css?v=1.7.6 [HTTP/1.1 304 Not Modified 8ms]
[14:08:26.642] GET https://crash-stats.stage.mozilla.com/js/socorro/nav.js?v=1.7.6.js [HTTP/1.1 304 Not Modified 9ms]
[14:08:26.867] GET https://crash-stats.stage.mozilla.com/img/__utm.gif?utmwv=6.1&utmn=1438978110&utmsr=1920x1200&utmsc=24-bit&utmul=en-us&utmje=1&utmjv=1.5&utmfl=10.1%20r102&utmcn=1&utmhn=crash-stats.stage.mozilla.com&utmr=0&utmp=/products/Firefox [HTTP/1.1 200 OK 8ms]
[14:08:28.689] GET https://crash-stats.stage.mozilla.com/topcrasher/bytopsite/Firefox/ [HTTP/1.1 302 Found 71ms]
[14:08:28.820] GET https://crash-stats.stage.mozilla.com/topcrasher/bytopsite/Firefox/3.6.12 [HTTP/1.1 200 OK 141ms]
[14:08:29.065] GET https://crash-stats.stage.mozilla.com/css/screen.css?v=1.7.6 [HTTP/1.1 304 Not Modified 155ms]
[14:08:29.105] GET https://crash-stats.stage.mozilla.com/js/socorro/nav.js?v=1.7.6.js [HTTP/1.1 304 Not Modified 142ms]
[14:08:29.330] GET https://crash-stats.stage.mozilla.com/img/__utm.gif?utmwv=6.1&utmn=1913373520&utmsr=1920x1200&utmsc=24-bit&utmul=en-us&utmje=1&utmjv=1.5&utmfl=10.1%20r102&utmcn=1&utmhn=crash-stats.stage.mozilla.com&utmr=0&utmp=/topcrasher/bytopsite/Firefox/3.6.12 [HTTP/1.1 200 OK 93ms]
[14:08:31.556] GET https://crash-stats.stage.mozilla.com/products/Thunderbird [HTTP/1.1 200 OK 84ms]
[14:08:31.769] GET https://crash-stats.stage.mozilla.com/css/screen.css?v=1.7.6 [HTTP/1.1 304 Not Modified 205ms]
[14:08:31.805] GET https://crash-stats.stage.mozilla.com/js/socorro/nav.js?v=1.7.6.js [HTTP/1.1 304 Not Modified 205ms]
[14:08:32.113] GET https://crash-stats.stage.mozilla.com/img/__utm.gif?utmwv=6.1&utmn=676782869&utmsr=1920x1200&utmsc=24-bit&utmul=en-us&utmje=1&utmjv=1.5&utmfl=10.1%20r102&utmcn=1&utmhn=crash-stats.stage.mozilla.com&utmr=0&utmp=/products/Thunderbird [HTTP/1.1 200 OK 103ms]
[14:08:33.032] GET https://crash-stats.stage.mozilla.com/topcrasher/bytopsite/Firefox/3.6.12 [HTTP/1.1 500 Internal Server Error 83ms]

Comment 6

[Ryan Snyder [:ryansnyder] [:rsnyder] [:rysny]]

The fix applied looks like it solved a different problem.  Here are the fixes for this problem.  

==

Sending        controllers/topcrasher.php
Transmitting file data .
Committed revision 2945.

Sending        application/libraries/MY_Controller.php
Transmitting file data .
Committed revision 2946.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED manually; Matt Brandt and I will continue to test around this (and he'll write the automated test, hot!)