607944 - Canary fails to build with --disable-libxul (missing symbol XRE_GetProcessType)

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Mats Palmgren (inactive)]

Canary fails to build with --disable-debug --disable-ipc.

/usr/bin/ld.gold.real: ../threads/libxpcomthreads_s.a(nsThread.o): in function nsThread::ProcessNextEvent(int, int*):nsThread.cpp(.text+0x643): error: undefined reference to 'XRE_GetProcessType'

Comment 1

[Mats Palmgren (inactive)]

Attachment: my workaround

Comment 2

[Mats Palmgren (inactive)]

It's probably more related to --disable-libxul than --disable-ipc
These mozconfig options should reproduce it:

ac_add_options --disable-ipc
ac_add_options --disable-libxul
ac_add_options --enable-shared-js
ac_add_options --enable-chrome-format=symlink
ac_add_options --disable-debug
ac_add_options --enable-optimize

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: another patch

Comment 4

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 486605 [details] [diff] [review]
another patch

I like Mats's approach better.  Let's do something like

  static bool EventLatencyIsImportant() {
    return NS_IsMainThread()
#ifdef MOZ_IPC
           && ProcessType() == Default

then check EventLatencyIsImportant() in the ctor and dtor.

Comment 5

[Ben Bucksch (:BenB)]

> It's probably more related to --disable-libxul than --disable-ipc

Confirmed.

Comment 7

[timeless]

Attachment: per cjones

Comment 8

[timeless]

Attachment: qrefreshed...

Comment 9

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/mozilla-central/rev/626c8e1c7245