607966 - Use of qw(...) as parentheses is deprecated since Perl 5.13.5

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect)

Description

[Frédéric Buclin]

Use of qw(...) as parentheses is deprecated at Bugzilla/Bug.pm line 1484.
Use of qw(...) as parentheses is deprecated at Bugzilla/CGI.pm line 163.
Use of qw(...) as parentheses is deprecated at Bugzilla/Search.pm line 1396.
Use of qw(...) as parentheses is deprecated at Bugzilla/WebService/Bug.pm line 934.
Use of qw(...) as parentheses is deprecated at chart.cgi line 203.
Use of qw(...) as parentheses is deprecated at editflagtypes.cgi line 115.


1484:    foreach my $type qw(dependson blocked) {
./Bugzilla/Bug.pm

934:    foreach my $field qw(creator attacher) {
./Bugzilla/WebService/Bug.pm

1396:        foreach my $field qw(assigned_to reporter cc qa_contact) {
./Bugzilla/Search.pm

162:            foreach my $field qw(type assigned_to reporter qa_contact
./Bugzilla/CGI.pm

383:    foreach my $field qw(assigned_to qa_contact reporter cc) {
507:    foreach my $type qw(a b) {
618:    foreach my $field qw(comments remaining_time percentage_complete
./xt/lib/Bugzilla/Test/Search.pm

115:    foreach my $boolean qw(is_active is_requestable is_requesteeble is_multiplicable) {
./editflagtypes.cgi

203:    foreach my $cat qw(category subcategory) {
./chart.cgi

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Frédéric Buclin]

I don't think we need to backport it to 3.6, though it wouldn't hurt.

Comment 3

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified chart.cgi
modified editflagtypes.cgi
modified Bugzilla/Bug.pm
modified Bugzilla/CGI.pm
modified Bugzilla/Search.pm
modified Bugzilla/WebService/Bug.pm
modified xt/lib/Bugzilla/Test/Search.pm
Committed revision 7581.


Committing to: bzr+ssh://[e-mail]/bugzilla/4.0/
modified chart.cgi
modified Bugzilla/Bug.pm
modified Bugzilla/CGI.pm
modified Bugzilla/WebService/Bug.pm
modified xt/lib/Bugzilla/Test/Search.pm
Committed revision 7466.

Comment 4

[Frédéric Buclin]

Only 3 places were affected in Bugzilla 3.6.2, and my patch applied cleanly there, so I committed it on the 3.6 branch too.

Committing to: bzr+ssh://[e-mail]/bugzilla/3.6/
modified chart.cgi
modified Bugzilla/Bug.pm
modified Bugzilla/CGI.pm
Committed revision 7197.